Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread David Kastrup
John Mandereau writes: > Il giorno ven, 29/06/2012 alle 11.00 +, gra...@percival-music.ca ha > scritto: >> LGTM, I think. I'm not completely certain what I'm reviewing here. >> >> I'm content to have this (whatever it is) go through, but in the future >> could you: >> - keep you changes in

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread John Mandereau
Il giorno ven, 29/06/2012 alle 11.00 +, gra...@percival-music.ca ha scritto: > LGTM, I think. I'm not completely certain what I'm reviewing here. > > I'm content to have this (whatever it is) go through, but in the future > could you: > - keep you changes in a separate git branch (locally) >

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-29 Thread graham
LGTM, I think. I'm not completely certain what I'm reviewing here. I'm content to have this (whatever it is) go through, but in the future could you: - keep you changes in a separate git branch (locally) - run: git cl upload origin/master while on that local git branch. Yes, this will "squis

Re: Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-27 Thread john . mandereau
Reviewers: Graham Percival, Message: I'm on submitting another patchset (later tonight). http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): http://codereview.appspot.com/6354044/diff/1/Documen

Patchset for fixing 2604 and 2524, also contains another patch for CG (issue 6354044)

2012-06-27 Thread graham
LGTM. One tweak, then it can be pushed directly to staging. http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): http://codereview.appspot.com/6354044/diff/1/Documentation/contributor/administra