Re: Patch for issue #1116 (one stencil in fill-line) (issue1689041)

On 2010/07/01 22:27:42, Neil Puttock wrote: Hi Alexander, LGTM. Thanks. It just needs some regression tests; the examples from #1116 and #382 should suffice. I did not write those - I'm not yet perfectly convinced that the handling of word-space is the right thing to do (see below). h

Re: Patch for issue #1116 (one stencil in fill-line) (issue1689041)

Reviewers: joeneeman, Neil Puttock, Message: On 2010/06/30 18:34:35, joeneeman wrote: Are you still waiting for someone to review this? Sorry, missed the notifications - I don't usually check my gmail account. http://codereview.appspot.com/1689041/diff/2001/3001#newcode848 scm/define-markup-

Re: Patch for issue #1116 (one stencil in fill-line) (issue1689041)

Hi Alexander, LGTM. It just needs some regression tests; the examples from #1116 and #382 should suffice. Cheers, Neil http://codereview.appspot.com/1689041/diff/2001/3001 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1689041/diff/2001/3001#newcode845 scm/define-

Patch for issue #1116 (one stencil in fill-line) (issue1689041)

Are you still waiting for someone to review this? If so, here are a couple minor things: http://codereview.appspot.com/1689041/diff/2001/3001 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1689041/diff/2001/3001#newcode848 scm/define-markup-commands.scm:848: X RIGHT