Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-17 Thread lemzwerg
What's the advantage? Harmonized, uniform syntax, but... A context property (which may well be defined at a later point of time in a layout definition) is not available for making that decision at the time it needs to be done. ... this explains why it doesn't work, thanks. https://coderevi

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-17 Thread dak
When replying to a code review, please at least keep the URL of the review in the body of the mail, or the review will not be visible on Rietveld. From: Werner LEMBERG Subject: Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044) To: d...@gnu.org, re...@codereview

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread Janek WarchoĊ‚
2014/1/16 : > On 2014/01/16 19:58:32, janek wrote: >> mus = { c'2 d'8 e' f' g' } >> text = \lyricmode { tro -- lo -- lo bing bong } >> >> << >>\new Staff \mus >>\new Lyrics \lyricsto \mus \text >> >> > > > Still meaningless as \lyricsto would have no way to guess the associated > context.

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread dak
On 2014/01/16 19:58:32, janek wrote: On 2014/01/16 19:57:11, janek wrote: > On 2014/01/16 19:55:40, dak wrote: > > On 2014/01/16 19:49:16, janek wrote: > > > So, does it mean that i'll be able to write > > > > > > \mus = { c'2 d'8 e' f' g' } > > > > > > << > > > \new Staff \mus > > > \new Lyr

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread dak
On 2014/01/16 19:57:11, janek wrote: On 2014/01/16 19:55:40, dak wrote: > On 2014/01/16 19:49:16, janek wrote: > > So, does it mean that i'll be able to write > > > > \mus = { c'2 d'8 e' f' g' } > > > > << > > \new Staff \mus > > \new Lyrics \lyricsto \mus > > >> > > > > ? > > What would make

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread janek . lilypond
On 2014/01/16 19:57:11, janek wrote: On 2014/01/16 19:55:40, dak wrote: > On 2014/01/16 19:49:16, janek wrote: > > So, does it mean that i'll be able to write > > > > \mus = { c'2 d'8 e' f' g' } > > > > << > > \new Staff \mus > > \new Lyrics \lyricsto \mus > > >> > > > > ? > > What would make

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread janek . lilypond
On 2014/01/16 19:55:40, dak wrote: On 2014/01/16 19:49:16, janek wrote: > So, does it mean that i'll be able to write > > \mus = { c'2 d'8 e' f' g' } > > << > \new Staff \mus > \new Lyrics \lyricsto \mus > >> > > ? What would make you even think that? "music identifiers like \mus are per

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread dak
On 2014/01/16 19:49:16, janek wrote: So, does it mean that i'll be able to write \mus = { c'2 d'8 e' f' g' } << \new Staff \mus \new Lyrics \lyricsto \mus >> ? What would make you even think that? https://codereview.appspot.com/53120044/

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread janek . lilypond
So, does it mean that i'll be able to write \mus = { c'2 d'8 e' f' g' } << \new Staff \mus \new Lyrics \lyricsto \mus ? https://codereview.appspot.com/53120044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailma

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread dak
On 2014/01/16 13:55:43, lemzwerg wrote: A side question: What about a syntax like \new Lyrics \with { lyricsto = "bla" } { bla al blob blob } to be in sync with other modes? How would that be "in sync with other modes"? You assign to a context variable that is not being used, an

Re: Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread lemzwerg
A side question: What about a syntax like \new Lyrics \with { lyricsto = "bla" } { bla al blob blob } to be in sync with other modes? https://codereview.appspot.com/53120044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists

Parser: harmonize \lyricsto and \addlyrics arguments (issue 53120044)

2014-01-16 Thread lemzwerg
LGTM. https://codereview.appspot.com/53120044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel