On 4/17/09 1:58 PM, "Neil Puttock" wrote:
> 2009/4/17 Carl D. Sorensen :
>
>> Does anybody *want* constant-thickness slurs or ties? I thought that
>> variable thickness was clearly better. I think that keeping inferior output
>> to avoid conversion problems is not a good decision. I'd rath
2009/4/17 Carl D. Sorensen :
> Does anybody *want* constant-thickness slurs or ties? I thought that
> variable thickness was clearly better. I think that keeping inferior output
> to avoid conversion problems is not a good decision. I'd rather force the
> user to make a simple manual change and
On 4/17/09 1:05 PM, "Neil Puttock" wrote:
> Carl, these are brilliant; they look wonderful.
Thanks for the compliment.
>
> I'm just looking through the patch at the moment, so I'll post
> comments (mainly trivial things) at Rietveld. I can't really comment
> on the implementation itself,
2009/4/17 Carl Sorensen :
> Carl D. Sorensen byu.edu> writes:
>
>>
>> Please review my patch for dashed slurs on rietveld:
>>
>> http://codereview.appspot.com/40122/show
>>
>
> I've revised my patch to eliminate some debug garbage that was
> left in the files, and to make the bezier subdivide rout
Carl D. Sorensen byu.edu> writes:
>
> Please review my patch for dashed slurs on rietveld:
>
> http://codereview.appspot.com/40122/show
>
I've revised my patch to eliminate some debug garbage that was
left in the files, and to make the bezier subdivide routine work for
any degree of bezier cu
>> Very nice! What do you think about making `dash-definition' either
>> accept a list of four parameters or a list of lists (with four
>> parameters each)? Then we could write
>>
>> #'(a b c d)
>>
>> and are not forced to use
>>
>> #'((a b c d))
>>
>> if the slur is not split into diffe
On 4/16/09 10:50 PM, "Werner LEMBERG" wrote:
>> Please review my patch for dashed slurs on rietveld:
>
> Very nice! What do you think about making `dash-definition' either
> accept a list of four parameters or a list of lists (with four
> parameters each)? Then we could write
>
> #'(a b
> Please review my patch for dashed slurs on rietveld:
Very nice! What do you think about making `dash-definition' either
accept a list of four parameters or a list of lists (with four
parameters each)? Then we could write
#'(a b c d)
and are not forced to use
#'((a b c d))
if the slur i
Please review my patch for dashed slurs on rietveld:
http://codereview.appspot.com/40122/show
It's my first patch with substantive changes in C++ code.
It enables variable-thickness dashed slurs, as well as
half-dashed/half-solid slurs.
You can see sample output in the attached png file.
Thank