Pushed as 8adeb99e344bf047b9b3b9b48a9e97e59e8fc4d3 and
71aa438bce0f68b0e8ab8c633b4902c971ede48b.
http://codereview.appspot.com/5233042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Thanks Neil, I'll make two commits. Do you want to see them both on
codereview?
Comment in lily-guile restored.
http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc
File lily/lily-guile.cc (left):
http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc#oldcode72
lily
Hi Betrand,
This should be split into two patches: one for the optimization and
another for adding robust_symbol2string lookups outside note-head.cc.
Cheers,
Neil
http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc
File lily/lily-guile.cc (left):
http://codereview.appspot.com/
Passes make and make check throws up no reg tests except graphviz.log:
--snip--
@@ -14,9 +14,9 @@
Writing graph `#f'...digraph G {
rankdir="LR"
node [shape=rectangle]
-41 [label="caching Stem.stencil\n# -> #"]
+41 [label="caching LedgerLineSpanner.stencil\n# -> #"]
40 [label="caching Vertical
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc
File lily/note-head.cc (right):
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79
lily/note-head.cc:79: out = fm->find_by_name (idx_either);
Unfortunately, this doesn't work. If the condition line 73 is false,
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc
File lily/note-head.cc (right):
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79
lily/note-head.cc:79: out = fm->find_by_name (idx_either);
This performs a second lookup for every note-head.
Move this call to
Reviewers: ,
Message:
Hi,
This is a try to increase performance, especially under Windows (see
http://code.google.com/p/lilypond/issues/detail?id=1926).
As I don't use Windows to compile LilyPond, can someone test it?
Regards,
Bertrand
Description:
Optimizes note-heads.cc and introduces robus
