Re: New breve rest with ledger lines (issue4650052)

2011-07-04 Thread Carl . D . Sorensen
LGTM Carl http://codereview.appspot.com/4650052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New breve rest with ledger lines (issue4650052)

2011-06-24 Thread bordage . bertrand
Yes, sorry for that. Just for information, ancient fonts are stored in the parmesan-* files. For the ancient fonts, we really need to think about a less hard-coded solution. http://codereview.appspot.com/4650052/ ___ lilypond-devel mailing list lilypon

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread k-ohara5a5a
On 2011/06/24 00:56:43, Bertrand Bordage wrote: You have to remove mf/out/feta* before compiling. That made everything work. Looks good to me. I was failing to find a glyph for rests.-1o , saw you were creating a new rests.M1o and thought "Oh, 'M' must mean mensural" but I see it really does

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread bordage . bertrand
Maybe I should have been more clear in the description. The glyph I added in feta-rests.mf is for the default style. You have to remove mf/out/feta* before compiling. There's no problem when I try this patch with your example. But again, maybe I don't understand what you mean. Thanks http://code

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread k-ohara5a5a
On 2011/06/23 09:34:23, Bertrand Bordage wrote: For the moment, the exception is handled by the next "if", line 100. But don't forget to let /something/ print if the ledgered version is missing in the chosen style -- especially default : \relative c''' { \time 4/1 << { b\breve\rest g\bre

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread percival . music . ca
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1705 http://codereview.appspot.com/4650052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New breve rest with ledger lines (issue4650052)

2011-06-23 Thread bordage . bertrand
Updated with the good bounds. The problem with mensural/neomensural/Petrucci styles is that they often have different ledger line thicknesses. The best solution is to get these ledger lines out of metafont. But this requires much more work. For the moment, the exception is handled by the next "i

Re: New breve rest with ledger lines (issue4650052)

2011-06-22 Thread k-ohara5a5a
What is required to demonstrate this ? I thought of \relative c'' { \override Staff.NoteHead #'style = #'mensural \override Staff.Rest #'style = #'mensural \time 4/2 << { g'1\rest b1\rest g\breve\rest b\breve\rest d\breve\rest } \\ { c,1 r2 r4 r4 r\breve r\breve r\breve } >>

New breve rest with ledger lines (issue4650052)

2011-06-22 Thread bordage . bertrand
Reviewers: , Message: Minor patch that adds a useful glyph for baroque music. Description: New breve rest with ledger lines Please review this at http://codereview.appspot.com/4650052/ Affected files: M lily/rest.cc M mf/feta-rests.mf Index: lily/rest.cc diff --git a/lily/rest.cc b/lily/