http://codereview.appspot.com/4848/diff/806/615
File lily/page-breaking.cc (right):
http://codereview.appspot.com/4848/diff/806/615#newcode227
Line 227: ly_symbol2scm ("is-part-last"), scm_from_bool (last),
On 2008/11/03 00:27:51, joeneeman wrote:
A really minor naming nitpick, but you have is-
Look good, just one nitpick.
http://codereview.appspot.com/4848/diff/806/615
File lily/page-breaking.cc (right):
http://codereview.appspot.com/4848/diff/806/615#newcode227
Line 227: ly_symbol2scm ("is-part-last"), scm_from_bool (last),
A really minor naming nitpick, but you have is-last and is-
Hi,
I've uploaded a 3rd patch. Compared with the 2nd (which addresses the
issues
raised by Joe), it implements two things:
- it is possible, in header and footer markups, to know whether a page
is the
first or last page of book or of a part, using the predicates
first-page
last-page
On Sat, Oct 18, 2008 at 08:10:29AM -0700, [EMAIL PROTECTED] wrote:
>
> Line 266: bool last_from_part = (i == lines_per_page.size () - 1);
> On 2008/10/15 01:06:06, joeneeman wrote:
>> I'm not sure this is the logic we want here. I think we want to treat
> the last
>> page in a bookpart the same as
http://codereview.appspot.com/4848/diff/1/4
File lily/book.cc (right):
http://codereview.appspot.com/4848/diff/1/4#newcode139
Line 139: Book::add_bookpart ()
On 2008/10/15 01:06:06, joeneeman wrote:
This method confused me for a while (because it has quite a different
purpose
from add_bookpar
http://codereview.appspot.com/4848/diff/1/5
File lily/include/book.hh (right):
http://codereview.appspot.com/4848/diff/1/5#newcode35
Line 35: void add_bookpart ();
On 2008/10/15 01:06:06, joeneeman wrote:
Can this be private? Yeah, I know everything else here is public, but
that's no
reason t
Reviewers: nicolas.sceaux,
Message:
I'm really sorry I took so long to do this. I honestly thought it had
already been committed (probably because it has been merged into my
working copy for such a long time).
http://codereview.appspot.com/4848/diff/1/4
File lily/book.cc (right):
http://codere
