Re: Move New_dynamic_engraver over the unused Dynamic_engraver (issue 14460043)

2013-10-06 Thread dak
On 2013/10/06 23:29:23, thomasmorley651 wrote: On 2013/10/06 23:10:16, dak wrote: > On 2013/10/06 23:00:25, thomasmorley651 wrote: [...] > > Or am I completely wrong and this patch has nothing to do with the problem > > above? > > In this case, you are completely wrong. [...] Anyway, thanks for

Re: Move New_dynamic_engraver over the unused Dynamic_engraver (issue 14460043)

2013-10-06 Thread thomasmorley65
On 2013/10/06 23:10:16, dak wrote: On 2013/10/06 23:00:25, thomasmorley651 wrote: [...] > Or am I completely wrong and this patch has nothing to do with the problem > above? In this case, you are completely wrong. [...] Anyway, thanks for clarifying. https://codereview.appspot.com/144600

Re: Move New_dynamic_engraver over the unused Dynamic_engraver (issue 14460043)

2013-10-06 Thread dak
On 2013/10/06 23:00:25, thomasmorley651 wrote: Although, I can't review C++, I've applied the patch for testing (hopefully without mistake) Testing this code { c''1_\mf^\> \break d''_\mp^\! } I've got: programming error: Spanner `Hairpin' is not fully contained in parent spanner.

Re: Move New_dynamic_engraver over the unused Dynamic_engraver (issue 14460043)

2013-10-06 Thread thomasmorley65
Although, I can't review C++, I've applied the patch for testing (hopefully without mistake) Testing this code { c''1_\mf^\> \break d''_\mp^\! } I've got: programming error: Spanner `Hairpin' is not fully contained in parent spanner. Ignoring orphaned part { c''1_\mf ^\> \break d''_