Hi,
after disappearing for some time (sorry for that) i'm reading my inbox
and found that guitar capo transposer isn't finished!
Wol, how can i help you? Would you like me to investigate the scheme
function about which you wrote on frogs list ("After capo handler
comes capo key")?
Maybe it would
On 02/08/11 21:24, n.putt...@gmail.com wrote:
>
> http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely
>
> File Documentation/notation/chords.itely (right):
>
> http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely#newcode516
>
> Do
http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely
File Documentation/notation/chords.itely (right):
http://codereview.appspot.com/4800051/diff/12002/Documentation/notation/chords.itely#newcode516
Documentation/notation/chords.itely:516: In make-pitch, leave the
W dniu 1 sierpnia 2011 16:47 użytkownik Wols Lists
napisał:
> On 31/07/11 23:35, Carl Sorensen wrote:
>> Do we need four bars? Why not just do three bars -- one with capoPitch '(),
>> another with capoPitch set, and a third with capoVertical?
>>
>> We like to get examples and regtests as simple a
On 31/07/11 23:35, Carl Sorensen wrote:
> On 7/31/11 4:17 PM, "Wols Lists" wrote:
>
>> On 31/07/11 22:00, Janek Warchoł wrote:
>>> 2011/7/31 Wols Lists :
Assuming that it's okay and is applied, I've redone my docu patch.
>>>
>>> Uploaded to Rietveld. I see one trailing whitespace (afte
Passes Make and reg tests
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch set uploaded (adding a regtest).
2011/8/1 Wols Lists :
Regression test attached. I've looked at the other regression tests
and
tried to make it similar.
Great!
http://codereview.appspot.com/4800051/diff/14003/input/regression/chord-capo.ly
File input/regression/chord-capo.ly (rig
On 7/31/11 4:17 PM, "Wols Lists" wrote:
> On 31/07/11 22:00, Janek Warchoł wrote:
>> 2011/7/31 Wols Lists :
>>>
>>> Assuming that it's okay and is applied, I've redone my docu patch.
>>
>> Uploaded to Rietveld. I see one trailing whitespace (after "By
>> default the chords are"), also there sh
On 31/07/11 22:00, Janek Warchoł wrote:
> 2011/7/31 Wols Lists :
>>
>> Assuming that it's okay and is applied, I've redone my docu patch.
>
> Uploaded to Rietveld. I see one trailing whitespace (after "By
> default the chords are"), also there should be two spaces after a
> period which ends sent
2011/7/31 Wols Lists :
>
> Assuming that it's okay and is applied, I've redone my docu patch.
Uploaded to Rietveld. I see one trailing whitespace (after "By
default the chords are"), also there should be two spaces after a
period which ends sentence.
> The snippet prints a four-bar phrase with j
On 31/07/11 11:35, lemniskata.bernoull...@gmail.com wrote:
> New patch uploaded. Passes regtests made from scratch.
>
> http://codereview.appspot.com/4800051/
>
Assuming that it's okay and is applied, I've redone my docu patch. The
snippet prints a four-bar phrase with just the standard chord (t
New patch uploaded. Passes regtests made from scratch.
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 31/07/11 00:22, Carl Sorensen wrote:
>
>
>
> On 7/30/11 5:15 PM, "Wols Lists" wrote:
>
>> On 30/07/11 23:52, Wols Lists wrote:
>>> On 30/07/11 22:49, pkx1...@gmail.com wrote:
Doesn't pass a make check.
I get an error on
regression/fret-diagrams-string-thickness.ly
>
On 7/30/11 5:15 PM, "Wols Lists" wrote:
> On 30/07/11 23:52, Wols Lists wrote:
>> On 30/07/11 22:49, pkx1...@gmail.com wrote:
>>> Doesn't pass a make check.
>>>
>>> I get an error on
>>>
>>> regression/fret-diagrams-string-thickness.ly
>>>
>>> log file shows:
>>>
>>> Renaming input to:
>>>
On 30/07/11 23:52, Wols Lists wrote:
> On 30/07/11 22:49, pkx1...@gmail.com wrote:
>> Doesn't pass a make check.
>>
>> I get an error on
>>
>> regression/fret-diagrams-string-thickness.ly
>>
>> log file shows:
>>
>> Renaming input to:
>> `/home/jlowe/lilypond-git/input/regression/fret-diagrams-stri
http://codereview.appspot.com/4800051/diff/10001/scm/chord-name.scm
File scm/chord-name.scm (right):
http://codereview.appspot.com/4800051/diff/10001/scm/chord-name.scm#newcode177
scm/chord-name.scm:177: (if (not capo-pitch)
Seems like a Lispism: '() evaluates as true. You probably should rathe
On 30/07/11 22:49, pkx1...@gmail.com wrote:
> Doesn't pass a make check.
>
> I get an error on
>
> regression/fret-diagrams-string-thickness.ly
>
> log file shows:
>
> Renaming input to:
> `/home/jlowe/lilypond-git/input/regression/fret-diagrams-string-thickness.ly'
>
> Interpreting music... E
Doesn't pass a make check.
I get an error on
regression/fret-diagrams-string-thickness.ly
log file shows:
Renaming input to:
`/home/jlowe/lilypond-git/input/regression/fret-diagrams-string-thickness.ly'
Interpreting music... ERROR: In procedure ly:pitch-transpose:
ERROR: Wrong type argument in
LGTM, but we need a regtest before pushing.
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch from Wol uploaded.
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 25/07/11 23:21, carl.d.soren...@gmail.com wrote:
> Wol,
Hi Carl
>
> Please fix the indentation, and make a new patch so that you get credit
> for the commit.
>
> Thanks,
>
> Carl
>
New patch attached. I've taken your patch, applied it, fixed the
indentation (I hope :-) and created the new o
Wol,
Please fix the indentation, and make a new patch so that you get credit
for the commit.
Thanks,
Carl
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-
Wol,
Please fix the indentation, and make a new patch so that you get credit
for the commit.
Thanks,
Carl
http://codereview.appspot.com/4800051/diff/3001/scm/chord-name.scm
File scm/chord-name.scm (right):
http://codereview.appspot.com/4800051/diff/3001/scm/chord-name.scm#newcode180
scm/cho
Uploaded Carl's fix, everything works now!
I'm making from scratch and will run regtests.
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
lemniskata.bernoull...@gmail.com writes:
> New patch from Wol uploaded. According to Carl, it addresses previous
> concerns; we only have a problem with Scheme syntax left.
More than one. You have too few parens after let, then too many around
capo-pitch and capo-vertical (I guess).
--
David
New patch from Wol uploaded. According to Carl, it addresses previous
concerns; we only have a problem with Scheme syntax left.
(don't run regtests on this yet)
http://codereview.appspot.com/4800051/
___
lilypond-devel mailing list
lilypond-devel@gnu.
Reviewers: carl.d.sorensen_gmail.com,
Description:
Modify chord-name-engraver to call capo-handler
Add capo properties to define-context-properties
Add capo-handler function for guitar chords
Please review this at http://codereview.appspot.com/4800051/
Affected files:
M lily/chord-name-en
27 matches
Mail list logo
