Re: Make operator= private in Scheme_hash_table (issue 557680043 by hanw...@gmail.com)

2020-04-13 Thread Hans Ã…berg
> On 13 Apr 2020, at 17:15, hanw...@gmail.com wrote: > > On 2020/04/13 14:55:12, hahnjo wrote: >> If the function is not meant to be implemented / used, it should be > explicitly >> deleted (C++11). > > Done. > > https://codereview.appspot.com/557680043/ One might prefer having a deleted oper

Re: Make operator= private in Scheme_hash_table (issue 557680043 by hanw...@gmail.com)

2020-04-13 Thread jonas . hahnfeld
LGTM https://codereview.appspot.com/557680043/

Re: Make operator= private in Scheme_hash_table (issue 557680043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 14:55:12, hahnjo wrote: > If the function is not meant to be implemented / used, it should be explicitly > deleted (C++11). Done. https://codereview.appspot.com/557680043/

Make operator= private in Scheme_hash_table (issue 557680043 by hanw...@gmail.com)

2020-04-13 Thread jonas . hahnfeld
If the function is not meant to be implemented / used, it should be explicitly deleted (C++11). https://codereview.appspot.com/557680043/