Re: Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc File lily/pitch.cc (right): https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc#newcode162 lily/pitch.cc:162: if (qt < int (sizeof (accname) / sizeof (accname[0]))) On 2020/02/01 21:19:46, Dan Eble wrote: > s

Re: Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

I approve of your use of braces for even single-statement blocks. https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc File lily/pitch.cc (right): https://codereview.appspot.com/581580043/diff/561400052/lily/pitch.cc#newcode162 lily/pitch.cc:162: if (qt < int (sizeof (accname) /

Re: Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

https://codereview.appspot.com/581580043/diff/557260048/lily/pitch.cc File lily/pitch.cc (right): https://codereview.appspot.com/581580043/diff/557260048/lily/pitch.cc#newcode162 lily/pitch.cc:162: if (qt >= 0 && qt < int (sizeof(accname) / sizeof(const char*))) { On 2020/02/01 11:19:12, Dan Ebl

Re: Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

https://codereview.appspot.com/581580043/diff/557260048/lily/pitch.cc File lily/pitch.cc (right): https://codereview.appspot.com/581580043/diff/557260048/lily/pitch.cc#newcode162 lily/pitch.cc:162: if (qt >= 0 && qt < int (sizeof(accname) / sizeof(const char*))) { Instead of casting to int and c

Make Pitch::to_string() more robust (issue 581580043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/581580043/