Re: MIDI: reset channel counters when done; issue 1678 (issue4757043)

2011-07-21 Thread n . puttock
LGTM. http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc File lily/staff-performer.cc (right): http://codereview.appspot.com/4757043/diff/1/lily/staff-performer.cc#newcode69 lily/staff-performer.cc:69: // For now, ask the last Staff_performer clean up during its finalize() fin

Re: MIDI: reset channel counters when done; issue 1678 (issue4757043)

2011-07-16 Thread Keith OHara
On Sat, 16 Jul 2011 08:11:02 -0700, wrote: Passes Make tests - I still get: --snip-- Interpreting music... -warning: MIDI channel wrapped around -warning: remapping modulo 16 MIDI output to The test output shows the change from the old behavior. Lines with '-' in front were present in

MIDI: reset channel counters when done; issue 1678 (issue4757043)

2011-07-16 Thread pkx166h
Passes Make tests - I still get: --snip-- @ -1,8 +1,6 @@ Parsing... Renaming input to: `/home/jlowe/lilypond-git/input/regression/midi-volume-equaliser.ly' Interpreting music... -warning: MIDI channel wrapped around -warning: remapping modulo 16 MIDI output to `/home/jlowe/lilypond-git/build/