Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-28 Thread percival . music . ca
I did an extra regtest comparison, and it's fine. Please push whenever's convenient. http://codereview.appspot.com/4520050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-25 Thread percival . music . ca
LGTM http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly File input/regression/midi-unisons.ly (right): http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly#newcode6 input/regression/midi-unisons.ly:6: @code{timidity -idvvv file.midi |g

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-24 Thread k-ohara5a5a
I have been successfully testing this patch for and want to push it within a couple of days. Now is a good time to review (even though Michael Duggan wrote the core of this patch seven years ago) because it gets us thinking about how to di

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-11 Thread md5i . mail
On 2011/05/11 23:12:08, Keith wrote: http://codereview.appspot.com/4520050/diff/9001/flower/include/pqueue.hh#newcode110 flower/include/pqueue.hh:110: void del (vsize i) Rather than change the 'flower' library to support deletion from the heap, I suggest we continue to use the ignore_ flag on

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-11 Thread k-ohara5a5a
Reviewers: md5i, Message: This looks good overall. I will test out my own suggestions, because if we can make a smaller change, it will be easier to follow through this complicated stretch of history in the MIDI-output code. http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh

MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-11 Thread md5i . mail
Small variable nit upon rereading this patch. No change in semantics. http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh File flower/include/pqueue.hh (right): http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh#newcode121 flower/include/pqueue.hh:121: vsiz