Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread Carl . D . Sorensen
On 2011/05/25 18:08:59, Keith wrote: On 2011/05/25 13:43:55, Carl wrote: > IIRC, part of the motivation for the new spacing algorithm was the desire to put > staves in fixed positions on the page, regardless of what else was around. > > Does this patch eliminate this possibility? No. Gr

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread k-ohara5a5a
On 2011/05/25 13:43:55, Carl wrote: IIRC, part of the motivation for the new spacing algorithm was the desire to put staves in fixed positions on the page, regardless of what else was around. Does this patch eliminate this possibility? No. This patch merely includes a spring component, whi

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-25 Thread Carl . D . Sorensen
IIRC, part of the motivation for the new spacing algorithm was the desire to put staves in fixed positions on the page, regardless of what else was around. Does this patch eliminate this possibility? If so, is it possible to disable it? I guess by setting padding to 0? http://codereview.apps

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread k-ohara5a5a
Reviewers: Trevor Daniels, joeneeman, Message: Thanks for comments. I'll wait one more day before I push. Description: Loose-lines honor padding between systems When placing a loose line (e.g. Lyrics) at the top or bottom of a system, include as a constraint the padding to the neighboring syste

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread joeneeman
lgtm http://codereview.appspot.com/4553060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread tdanielsmusic
Looks ok to me, although I haven't tested it. Need Joe's LGTM to push. http://codereview.appspot.com/4553060/diff/7001/input/regression/page-spacing-nonstaff-lines-between-2.ly File input/regression/page-spacing-nonstaff-lines-between-2.ly (right): http://codereview.appspot.com/4553060/diff/700