Karl Hammar:
> Neil Puttock:
...
> > I basically do what Carl outlined in the other thread:
> >
> > make test-baseline
> >
> > git apply issue931041_1.diff
> >
> > make check
>
> The contributor manual says (3.6.3.1):
>
>* Initial test:
>
> make [-jX]
> make test-basel
On Sun, May 16, 2010 at 4:20 PM, Neil Puttock wrote:
> On 16 May 2010 16:12, Graham Percival wrote:
>
>> Oops, I meant to update this once it forgot.
>> The diff from fixcc.py is 724 K.
>
> Is that with emacs 23 installed? I seem to recall there was a wide
> variation in indentation between 22 a
On 16 May 2010 16:12, Graham Percival wrote:
> Oops, I meant to update this once it forgot.
> The diff from fixcc.py is 724 K.
Is that with emacs 23 installed? I seem to recall there was a wide
variation in indentation between 22 and 23.
There are many things still wrong with fixcc.py, but it
On Sun, May 16, 2010 at 4:06 PM, Graham Percival
wrote:
> If anybody thinks that the first couple of items on the above list are
> already done, I don't want to hear about it. Running fixcc.py on the
> /lily/ dir produces a diff that's over 100 kb; refering to this as
> having our desires "pinned
On Sun, May 16, 2010 at 4:06 PM, James Lowe wrote:
> Hello,
>
> Does that mean we need to change/edit remove something from the CG?
Yes, but not from you. People who know enough about regtests that
could fix that text can change this themselves. Going through a third
party would only show thing
On Sun, May 16, 2010 at 4:02 PM, Neil Puttock wrote:
> On 16 May 2010 14:35, Karl Hammar wrote:
>
>> Does it matter, if not, why is in the contributor manual ?
>
> I think the instructions were lifted directly from the old (2.10)
> docs, so there may well have been changes to the test suite since
Hello,
On 16 May 2010, at 16:02, Neil Puttock wrote:
On 16 May 2010 14:35, Karl Hammar wrote:
Does it matter, if not, why is in the contributor manual ?
I think the instructions were lifted directly from the old (2.10)
docs, so there may well have been changes to the test suite since they
On Sun, May 16, 2010 at 2:35 PM, Karl Hammar wrote:
> Neil Puttock:
>> > Also, it would be much easier to look throuht the patch if it did not
>> > contain so many whitespace changes. In the first 100lines, I see:
>>
>> Why would you want to look at the bare diff?
>
> Isn't the diff a complete sta
On 16 May 2010 14:35, Karl Hammar wrote:
> Does it matter, if not, why is in the contributor manual ?
I think the instructions were lifted directly from the old (2.10)
docs, so there may well have been changes to the test suite since they
were written. TBH, when I started doing regression test
Neil Puttock:
> On 15 May 2010 14:37, Karl Hammar wrote:
> > git-pull
> > wget http://codereview.appspot.com/download/issue931041_1.diff
> > patch -p1 < issue931041_1.diff --dry-run
> > patch -p1 < issue931041_1.diff
> > make > log 2>&1; make test-redo >> log 2>&1
>
> I very rarely use `make test
On 15 May 2010 14:37, Karl Hammar wrote:
> git-pull
> wget http://codereview.appspot.com/download/issue931041_1.diff
> patch -p1 < issue931041_1.diff --dry-run
> patch -p1 < issue931041_1.diff
> make > log 2>&1; make test-redo >> log 2>&1
I very rarely use `make test-redo'.
I basically do what
Neil Puttock:
> On 15 May 2010 09:58, Karl Hammar wrote:
> > Patching with [3] (see [2]) still gives something (see attachment)
> > more like rest-2.12.png in [1], i.e. it was not fixed.
>
> You must've done something wrong when applying the patch/rebuilding.
>
> I wouldn't post a patch on Rietv
On 15 May 2010 09:58, Karl Hammar wrote:
> Patching with [3] (see [2]) still gives something (see attachment)
> more like rest-2.12.png in [1], i.e. it was not fixed.
You must've done something wrong when applying the patch/rebuilding.
I wouldn't post a patch on Rietveld without first confirming
Patching with [3] (see [2]) still gives something (see attachment)
more like rest-2.12.png in [1], i.e. it was not fixed.
The comment for the fix:
Allow user override of left/right spacing of full-bar rests relative
to barlines or prefatory material.
implies that one has to do an override. T
14 matches
Mail list logo
