Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-07-07 Thread dak
https://codereview.appspot.com/103890046/diff/250001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/103890046/diff/250001/ly/music-functions-init.ly#newcode718 ly/music-functions-init.ly:718: \context Voice { This would create a new Staff when

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-07-06 Thread markpolesky
On 2014/07/06 14:04:07, dak wrote: ly/music-functions-init.ly:645: Stem.thickness This is madness. Stem.thickness and its ilk don't make sense as symbols at all Okay ly/music-functions-init.ly:679: Slur.details.region-size I doubt you even have a chance of making this work. Overriding and

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-07-06 Thread dak
Yeah, I know. Late again. I was really having problems catching up with various things. https://codereview.appspot.com/103890046/diff/360001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/103890046/diff/360001/ly/music-functions-init.ly#newc

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-07-04 Thread paulwmorris
I happened to notice one little thing while I was skimming through this (i.e. not a full review, for which I'm not really qualified). https://codereview.appspot.com/103890046/diff/280001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/103890046/diff/

Re: Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-30 Thread markpolesky
This new patch went through a countdown cycle without any reviews. I'm putting it through another cycle in case anyone would like to make comments before I push it. Thanks. - Mark https://codereview.appspot.com/103890046/ ___ lilypond-devel mailing l

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-20 Thread markpolesky
On 2014/06/15 05:25:27, dak wrote: It would have helped if I had written the correct command to use. It is, of course, \applyContext. The documentation does not help much, but one illustrative read/modify/write use is in scm/music-functions.scm in add-grace-property and remove-grace-property.

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-14 Thread David Kastrup
markpole...@gmail.com writes: > On 2014/06/14 06:58:52, dak wrote: >>> On 2014/06/06 09:29:03, Mark Polesky wrote: >>> ... Ideally, if the user has already >>> modified some of those values, I'd like to base the new scaled values > on >>> the user's choices, and not base them on the LilyPond defau

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046 by markpole...@gmail.com)

2014-06-14 Thread markpolesky
On 2014/06/14 06:58:52, dak wrote: On 2014/06/06 09:29:03, Mark Polesky wrote: ... Ideally, if the user has already modified some of those values, I'd like to base the new scaled values on the user's choices, and not base them on the LilyPond default values. If that's possible at all, I don't k

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-06-14 Thread David Kastrup
markpole...@gmail.com writes: > On 2014/06/06 09:29:03, Mark Polesky wrote: >> Please review this new patch. I'm not entirely sure this >> is the right approach, so I may need some advice here. > > This patch has gone through the review/countdown process without a > single comment or review, but

Re: Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-06-13 Thread markpolesky
On 2014/06/06 09:29:03, Mark Polesky wrote: Please review this new patch. I'm not entirely sure this is the right approach, so I may need some advice here. This patch has gone through the review/countdown process without a single comment or review, but I'm not comfortable pushing it without an

Issue 3942: Scale slurs and ties when using \magnifyMusic. (issue 103890046)

2014-06-06 Thread markpolesky
Reviewers: , Message: Please review this new patch. I'm not entirely sure this is the right approach, so I may need some advice here. Thank you! - Mark Description: This is a (possibly misguided) attempt to get slurs and ties to scale properly when using \magnifyMusic. For the most part, I've