Hi Paul,
thanks for review
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm
File scm/markup.scm (right):
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm#newcode141
scm/markup.scm:141: ;; The string is split at line-breaks, emty strings
removed and finally
O
On 2018/11/11 15:08:57, thomasmorley651 wrote:
simplify, catch string-markups
patch-set 3 reflects my musing in comment #5
https://codereview.appspot.com/34743/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman
Hi Harm, I took a quick look and it LGTM at a quick read. I have a
couple nit-level suggestions.
-Paul
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm
File scm/markup.scm (right):
https://codereview.appspot.com/34743/diff/40001/scm/markup.scm#newcode141
scm/markup.scm:141
On 2018/11/11 11:07:35, dak wrote:
On 2018/11/11 10:57:31, thomasmorley651 wrote:
> 'all-relevant-markup-commands' tries to get all
markup-(list-)commands where
> 'markup->string' may return reasonable output.
I have to get used to the thought of not having the monopoly on good
ideas.
T
On 2018/11/11 10:57:31, thomasmorley651 wrote:
On 2018/11/10 12:53:18, dak wrote:
> I wonder whether it might be reasonable to just have all markup
commands with
a
> last argument of markup? produce their last (recursively treated)
argument as
> default, and possibly all markup list commands
On 2018/11/10 12:53:18, dak wrote:
I wonder whether it might be reasonable to just have all markup
commands with a
last argument of markup? produce their last (recursively treated)
argument as
default, and possibly all markup list commands with a last argument of
markup-list? similarly produc
I wonder whether it might be reasonable to just have all markup commands
with a last argument of markup? produce their last (recursively treated)
argument as default, and possibly all markup list commands with a last
argument of markup-list? similarly produce their last argument? That
leaves fewe
Reviewers: ,
Message:
Please review.
There are some TODOs in the code where I'd appreciate some feedback.
Thanks-
Description:
Improve markup->string
'all-relevant-markup-commands' is now a toplevel-defined procedure.
So it is not longer a part of the rekursive 'markup->string'.
It needs to be
