Urs Liska writes:
> Am 23.12.2015 um 10:06 schrieb d...@gnu.org:
>> On 2015/12/23 07:59:26, git wrote:
>>> Revert changes to snippets file
>>
>> At the current point of time, you only added
>> Documentation/snippets/new/xxx.ly while keeping
>> Documentation/snippets/xxx.ly unchanged. That's the
Am 23.12.2015 um 10:06 schrieb d...@gnu.org:
> On 2015/12/23 07:59:26, git wrote:
>> Revert changes to snippets file
>
> At the current point of time, you only added
> Documentation/snippets/new/xxx.ly while keeping
> Documentation/snippets/xxx.ly unchanged. That's the right organisation
> for a
On 2015/12/23 07:59:26, git wrote:
Revert changes to snippets file
At the current point of time, you only added
Documentation/snippets/new/xxx.ly while keeping
Documentation/snippets/xxx.ly unchanged. That's the right organisation
for a commit keeping manual and automatic changes apart. The a
On 12/22/15 1:31 PM, "lilypond-devel-bounces+c_sorensen=byu@gnu.org on
behalf of Urs Liska" wrote:
>
>So basically I can simply remove the changes to that file from my patch
>and upload it again, isn't it?
Yes.
Carl
___
lilypond-devel mailing
Am 22.12.2015 um 20:51 schrieb Carl Sorensen:
> Copy the snippet to Documentation/snippets/new.
>
> Remove the machine-generated header.
>
> Make your changes.
>
> Submit the patch.
OK, that is more or less what I did (in patch set 2).
The only thing that is left for me to update is *not* to inc
Copy the snippet to Documentation/snippets/new.
Remove the machine-generated header.
Make your changes.
Submit the patch.
Carl
On 12/22/15 11:34 AM, "g...@ursliska.de" wrote:
>
>https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets
>/subdividing-beams.ly
>File Documentat
On 2015/12/22 18:34:43, git wrote:
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly
File Documentation/snippets/subdividing-beams.ly (right):
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly
File Documentation/snippets/subdividing-beams.ly (right):
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7
Documentation/snippets/subdividing-be
Thanks for the comments, changes uploaded.
https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.ly
File Documentation/snippets/new/subdividing-beams.ly (right):
https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.l
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly
File Documentation/snippets/subdividing-beams.ly (right):
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7
Documentation/snippets/subdividing-be
THe code looks good to me. Just some minor details to look at.
https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.ly
File Documentation/snippets/new/subdividing-beams.ly (right):
https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/ne
11 matches
Mail list logo
