Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

On Mar 11, 2011, at 2:44 PM, Han-Wen Nienhuys wrote: > Hi Mike, > > can fix the below points before continuing with pushing stuff for this > patch series? > > On Sun, Mar 6, 2011 at 8:46 PM, wrote: >> +// ugh...code dup...hopefully can be consolidated w/ above one day > > can you make a prior

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

Hi Mike, can fix the below points before continuing with pushing stuff for this patch series? On Sun, Mar 6, 2011 at 8:46 PM, wrote: > +// ugh...code dup...hopefully can be consolidated w/ above one day can you make a priority to do this right now? If it's not done directly, 'one day' usually

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

On Mar 7, 2011, at 11:27 PM, n.putt...@gmail.com wrote: > LGTM. > > > http://codereview.appspot.com/4254055/diff/6001/lily/balloon.cc > File lily/balloon.cc (right): > > http://codereview.appspot.com/4254055/diff/6001/lily/balloon.cc#newcode47 > lily/balloon.cc:47: if (Item *item = dynamic_cast

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

LGTM. http://codereview.appspot.com/4254055/diff/6001/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4254055/diff/6001/lily/balloon.cc#newcode47 lily/balloon.cc:47: if (Item *item = dynamic_cast(me)) dynamic_cast (me)) http://codereview.appspot.com/4254055/ __

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

Reviewers: Neil Puttock, Message: Thanks Neil! New patch set uploaded. Cheers, Mike http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38 lily/balloon.cc:38: static SCM internal_balloo

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180 scm/define-grobs.scm:180: (annotation-balloon . #f) On 2011/03/06 23:35:28, Neil Puttock wrote: remove Oops, I mean

Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

Hi Mike, Just a few minor nitpicks for you. Cheers, Neil http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38 lily/balloon.cc:38: static SCM internal_balloon_print (Grob *me, Grob *p,