some small comments, please apply
http://codereview.appspot.com/11046/diff/19/205
File scm/flag-styles.scm (right):
http://codereview.appspot.com/11046/diff/19/205#newcode20
Line 20: Note that here length is the whole length, while flag-x-width
is just the
drop: Note that
http://codereview.app
ust do (* direction thick) to have a direction
dependent value.
http://codereview.appspot.com/11046/diff/8/11#newcode80
Line 80: (if (null? stroke-style)
use explicit check
(eq? stroke-style 'grace)
(or whatever)
Description:
Implement straight flags in scheme
Please review t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Sonntag, 14. Dezember 2008 03:44:52 schrieb hanw...@gmail.com:
> http://codereview.appspot.com/11046/diff/8/11
[...]
> Description:
> Implement straight flags in scheme
>
> Please review this at http://codereview.appspot.com/110
On Sun, Dec 14, 2008 at 1:36 AM, wrote:
> http://codereview.appspot.com/11046/diff/8/11#newcode28
> Line 28: (let* ((conversion-constant (/ (atan 1 1) 45))
> On 2008/12/14 02:44:52, hanwenn wrote:
>>
>> define PI = 3.141.. somewhere and use that.
>
> How about (define PI-OVER-180 (/ (atan 1 1) 4
