On 8/13/09 11:21 AM, "Michael Käppler" wrote:
> Hi Carl,
>>> Am I right you suggest to modify the output-def just once but permanent?
>>>
>>
>> I meant to change the paper-def so that it would be consistent for the rest
>> of the processing (it would eliminate multiple warnings).
>>
> O
Carl Sorensen writes:
> On 8/12/09 11:15 AM, "Michael Käppler" wrote:
>
>> Sorry, that wasn't intended. It was late yesterday and I didn't
>> notice I pressed the wrong button... ;)
>
> Glad I'm not the only one who does this.
Uh oh. Did you manage to placate her again?
--
David Kastrup
_
On 8/12/09 11:15 AM, "Michael Käppler" wrote:
> Hi Carl,
>> Usually we like to keep responses to reviews on the -devel list, so I've
>> copied this there.
>>
> Sorry, that wasn't intended. It was late yesterday and I didn't notice I
> pressed the wrong button... ;)
Glad I'm not the only one
Hi Carl,
Usually we like to keep responses to reviews on the -devel list, so I've
copied this there.
Sorry, that wasn't intended. It was late yesterday and I didn't notice I
pressed the wrong button... ;)
Oh -- I misunderstood the meaning of the FIXME.
I think I'd recommend changing the set
On Wed, 2009-08-12 at 09:14 -0400, Dan Eble wrote:
> On 12 Aug 2009, at 00:06, joenee...@gmail.com wrote:
>
> > In case there is rounding, it is better to check
> > if (abs (paper_width - line_width - left_margin - right_margin) >
> > 1e-6)
>
> Wouldn't it be a good idea to define a name for 1e
On 12 Aug 2009, at 00:06, joenee...@gmail.com wrote:
In case there is rounding, it is better to check
if (abs (paper_width - line_width - left_margin - right_margin) >
1e-6)
Wouldn't it be a good idea to define a name for 1e-6?
--
Dan
___
lilypo
Could you add some regression tests (doesn't have to be in this commit)
that demonstrate some of the possible combinations of margin settings?
There should also be some tests that demonstrate the warnings.
http://codereview.appspot.com/104085/diff/1/4
File lily/output-def.cc (right):
http://cod
Thanks for the reply Michael.
Usually we like to keep responses to reviews on the -devel list, so I've
copied this there.
On 8/11/09 5:51 PM, "Michael Käppler" wrote:
> Hi Carl,
> thanks for your review:
>> Don't use lmargin, rmargin, and lwidth as variable names. LilyPond
>> standards c
