http://codereview.appspot.com/109051/diff/1/5
File lily/output-def.cc (right):
http://codereview.appspot.com/109051/diff/1/5#newcode146
Line 146: if (scm_paper_width != SCM_UNDEFINED
On 2009/08/20 12:54:08, Carl wrote:
I'd prefer to see this and all of your checks for SCM_UNDEFINED) be
written
Hi Carl,
LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think
there's less chance of confusion when testing for "undefined" rather
than "not undefined", which is "defined". The double negative (not
undefined) can potentially be confusing.
that's a good point. However, I'm goi
LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think
there's less chance of confusion when testing for "undefined" rather
than "not undefined", which is "defined". The double negative (not
undefined) can potentially be confusing.
But this is just my opinion, and you can feel
