Re: Getting beam subdivision working

On Jun 19, 2023, at 13:21, Jason Yip wrote: > \set minSubdivideInterval = #(ly:make-moment 1 8) > \set maxSubdivideInterval = #(ly:make-moment 1 16) These values could be `\musicLength 8` and `\musicLength 16`. Also, MR 2032 (merged hours ago) adds `musical-length?` and `positive-musical-le

Re: Getting beam subdivision working

Jason, This work is looking amazing.. Great job! I think I like the idea of a Moment rather than a Duration right now. Part of me thought we might want to just use beam_count (which is the equivalent of a dur_log). But as is mentioned in Urs's document, that would preclude any numerator other

Re: Getting beam subdivision working

On 2023-06-17 06:27, David Kastrup - dak(a)gnu.org wrote: David Kastrup writes: Dan Eble writes: On Jun 16, 2023, at 19:13, Jason Yip wrote: minSubdivideInterval and maxSubdivideInterval. They are both Rationals. Their numerator and denominator must be a power of 2. For each power of 2 (

Re: Getting beam subdivision working

On Jun 17, 2023, at 09:27, David Kastrup wrote: > >> >> That sounds like it would make more sense to specify those values in the >> form of a "duration log", like the first argument to a ly:make-duration >> call. > > Or just use a duration in the first place. First iterations would > likely on

Re: Getting beam subdivision working

David Kastrup writes: > Dan Eble writes: > >> On Jun 16, 2023, at 19:13, Jason Yip wrote: >>> >>> minSubdivideInterval and maxSubdivideInterval. They are both >>> Rationals. Their numerator and denominator must be a power of 2. For >>> each power of 2 (including negative powers of 2 of course)

Re: Getting beam subdivision working

Dan Eble writes: > On Jun 16, 2023, at 19:13, Jason Yip wrote: >> >> minSubdivideInterval and maxSubdivideInterval. They are both >> Rationals. Their numerator and denominator must be a power of 2. For >> each power of 2 (including negative powers of 2 of course) That's redundant. It just mea

Re: Getting beam subdivision working

On Jun 16, 2023, at 19:13, Jason Yip wrote: > > minSubdivideInterval and maxSubdivideInterval. They are both Rationals. Their > numerator and denominator must be a power of 2. For each power of 2 > (including negative powers of 2 of course) between those two values, the beam > can be subdivide

Re: Getting beam subdivision working

On 2023-06-16 17:26, Carl Sorensen - carl.d.sorensen(a)gmail.com wrote: Before you work too hard on beam-subdivide-tuplets.ly , you may wish to investigate Urs's comment on local beat structure for tuplets.  As far as I know now, you don't have a beat struct

Re: Getting beam subdivision working

Jason, Great work! On Fri, Jun 16, 2023 at 5:23 PM Jason Yip wrote: > Hey all, > > > > The other "failing" regression tests concern the purpose of baseMoment. > > https://gitlab.com/lilypond/lilypond/uploads/9f968b929162a0d70d212ac2e99ec841/beam-subdivisions--notes-for-reimplementation--urs-lis

Re: Getting beam subdivision working

On 2023-06-16 16:26, Jean Abou Samra - jean(a)abou-samra.fr wrote: Le vendredi 16 juin 2023 à 16:13 -0700, Jason Yip a écrit : My implementation is available in a private fork, I'm not sure how I should share it if any other developers want to examine it (manual invite to each one who wants it?)

Re: Getting beam subdivision working

Le vendredi 16 juin 2023 à 16:13 -0700, Jason Yip a écrit : > My implementation is available in a private fork, I'm not sure how I > should share it if any other developers want to examine it (manual > invite to each one who wants it?) It's a bit messy at the moment and > definitely needs more c