generally signed-unsigned problems are better solved
by casting to size_t, not to unsigned - size_t works
equally well in 32 bit and 64 bit mode. (even better,
some variables can be size_t instead of int.)
p
___
lilypond-devel mailing list
lilypond-dev
Passes make but there are some reg test differences
see
http://code.google.com/p/lilypond/issues/detail?id=804#c6
http://codereview.appspot.com/4854049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lil
On 2011/08/10 05:19:42, Graham Percival wrote:
input/regression/completion-heads-factor.ly:12: \paper {
#(set-paper-size "a6")
}
is this part of the compiler warnings patch?
sorry, ignore that, I only just looked at the changelog message.
http://codereview.appspot.com/4854049/
_
http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly
File input/regression/completion-heads-factor.ly (right):
http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly#newcode12
input/regression/completion-heads-factor.ly:
Reinhold Kainhofer kainhofer.com> writes:
LGTM
Am Freitag, 5. August 2011, 21:22:49 schrieb Keith OHara:
> The entire source tree generates only seven warnings, all but one of
which
> point to code we could write more clearly.
Ah, great. Will you try to fix them?
You beat me to it :-)
LGTM, with a few comments.
Thanks,
Carl
http://codereview.appspot.com/4854049/diff/2001/lily/skyline.cc
File lily/skyline.cc (right):
http://codereview.appspot.com/4854049/diff/2001/lily/skyline.cc#newcode417
lily/skyline.cc:417: buildings_ = internal_build_skyline (&boxes,
horizon_padding,
