Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-12 Thread Chris Snyder
Joe Neeman wrote: > Now I'm even more confused. get_current_note_head finds a note head > (from the associatedVoice) that ends strictly after the current moment. > We only check melisma_busy if get_current_note_head finds something. > Therefore, we will only check melisma_busy if we are in the mid

Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Joe Neeman
On Wed, 2009-11-11 at 14:41 -0500, Chris Snyder wrote: > >> 1) Change melisma_busy() to return true if in the middle of a note > >> 2) Alternatively, add the check in > >> Extender_engraver::stop_translation_timestep instead > > > > I'm confused: isn't the current check in > > Extender_engrave

Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Chris Snyder
>> 1) Change melisma_busy() to return true if in the middle of a note >> 2) Alternatively, add the check in >> Extender_engraver::stop_translation_timestep instead > > I'm confused: isn't the current check in > Extender_engraver::stop_translation_timestep? For solution #2, I meant that we can add

Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Joe Neeman
On Wed, 2009-11-11 at 10:33 -0500, Chris Snyder wrote: > I've done some work towards fixing issue 800, and at least now > understand what's happening: > > The patch that introduced the bug added a check in > Extender_engraver::stop_translation_timestep() to check if the current > voice was in t

Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Chris Snyder
I've done some work towards fixing issue 800, and at least now understand what's happening: The patch that introduced the bug added a check in Extender_engraver::stop_translation_timestep() to check if the current voice was in the middle of a melisma (calling melisma_busy(voice) ) and, if not