Re: Fixing issue #44

2006-10-15 Thread Erlend Aasland
On 10/14/06, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: Can you close the issue and add a fixed2924 tag ? I've added you as aproject member.Ok, done that.Erlend ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/

Re: Fixing issue #44

2006-10-14 Thread Han-Wen Nienhuys
Han-Wen Nienhuys schreef: Erlend Aasland schreef: Hi, On 10/12/06, *Erlend Aasland* <[EMAIL PROTECTED] > wrote: I think the correct patch is making sure that the undotted note head also is in the support of the side-position-interface for dot

Re: Fixing issue #44

2006-10-13 Thread Han-Wen Nienhuys
Erlend Aasland schreef: Hi, On 10/12/06, *Erlend Aasland* <[EMAIL PROTECTED] > wrote: I think the correct patch is making sure that the undotted note head also is in the support of the side-position-interface for dot-column. Ok, done that,

Re: Fixing issue #44

2006-10-12 Thread Erlend Aasland
Hi,On 10/12/06, Erlend Aasland <[EMAIL PROTECTED]> wrote: I think the correct patch is making sure thatthe undotted note head also is in the support of the side-position-interface for dot-column. Ok, done that, patch attached. However, I'm not convinced that this is the best solution to the problem

Re: Fixing issue #44

2006-10-12 Thread Erlend Aasland
Hi Han-WenOn 10/12/06, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: > It fixes the bug, but I guess using the side-position> interface in some clever way can get rid of the magic numbers. Comments?Unfortunately, my music typography books are packed, so I can't access them, but all dots (of all voice

Re: Fixing issue #44

2006-10-12 Thread Han-Wen Nienhuys
Erlend Aasland schreef: Hello, I had a look at issue #44 yesterday and came up with this patch (attached). It fixes the bug, but I guess using the side-position interface in some clever way can get rid of the magic numbers. Comments? Unfortunately, my music typography books are packed, so

Fixing issue #44

2006-10-12 Thread Erlend Aasland
Hello,I had a look at issue #44 yesterday and came up with this patch (attached). It fixes the bug, but I guess using the side-position interface in some clever way can get rid of the magic numbers. Comments? diff -u -r1.71 note-collision.cc--- lily/note-collision.cc  17 Sep 2006 11:02:29 -