On 11-11-08 05:26 AM, Adam Spiers wrote:
On Tue, Nov 8, 2011 at 1:10 AM, Colin Campbell wrote:
On 11-11-07 12:08 PM, adam.spi...@gmail.com wrote:
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
Adam, yo
On Tue, Nov 8, 2011 at 1:10 AM, Colin Campbell wrote:
> On 11-11-07 12:08 PM, adam.spi...@gmail.com wrote:
>>
>> Please close this issue as it's now superceded by
>> http://codereview.appspot.com/5343050/ - thanks!
>>
>> http://codereview.appspot.com/5320074/
>
> Adam, you are the creator of the R
On 11-11-07 12:08 PM, adam.spi...@gmail.com wrote:
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https:/
Please close this issue as it's now superceded by
http://codereview.appspot.com/5343050/ - thanks!
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Mon, Nov 07, 2011 at 02:44:01PM +, Adam Spiers wrote:
> On Mon, Nov 7, 2011 at 2:11 PM, Graham Percival
> wrote:
> > The google code issue is our pointer. Rietveld is our memory. We
>
> Sure, but it's the de-referencing which worries me for two reasons:
>
> 1. These older review issues
On Mon, Nov 7, 2011 at 2:13 PM, Graham Percival
wrote:
> On Mon, Nov 07, 2011 at 12:44:42PM +, Carl Sorensen wrote:
>> I'll get the update posted today. For this patch, I'm serving as
>> adam's frog meister since last Thursday.
>
> Adam is a very experienced developer, and he already knows how
On Mon, Nov 7, 2011 at 2:11 PM, Graham Percival
wrote:
> On Mon, Nov 07, 2011 at 12:34:15PM +, Adam Spiers wrote:
>> On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
>> wrote:
>> > I doubt it. Just upload a new issue.
>>
>> So then we would have *three* Rietveld issues tracking the
>> same t
On Mon, Nov 07, 2011 at 12:44:42PM +, Carl Sorensen wrote:
>
> I'll get the update posted today. For this patch, I'm serving as
> adam's frog meister since last Thursday.
Adam is a very experienced developer, and he already knows how to
use git-cl. He's even patched it! He's not a frog, so
On Mon, Nov 07, 2011 at 12:34:15PM +, Adam Spiers wrote:
> On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
> wrote:
> > I doubt it. Just upload a new issue.
>
> So then we would have *three* Rietveld issues tracking the
> same thing.
The google code issue is our pointer. Rietveld is our m
On Nov 7, 2011, at 5:34 AM, "Adam Spiers" wrote:
> On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
> wrote:
>> On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
>>> Thanks Carl, I've made these changes, and I've also made a corresponding
>>> patch for changes.tely, but I
On Mon, Nov 7, 2011 at 12:12 PM, Graham Percival
wrote:
> On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
>> Thanks Carl, I've made these changes, and I've also made a corresponding
>> patch for changes.tely, but I don't think I have permission to upload
>> new patch sets fo
On Mon, Nov 07, 2011 at 11:56:42AM +, adam.spi...@gmail.com wrote:
> Thanks Carl, I've made these changes, and I've also made a corresponding
> patch for changes.tely, but I don't think I have permission to upload
> new patch sets for either to this issue since it says "Can't Edit" at
> the top
Thanks Carl, I've made these changes, and I've also made a corresponding
patch for changes.tely, but I don't think I have permission to upload
new patch sets for either to this issue since it says "Can't Edit" at
the top-left - can you give me permission? (If not, this is yet another
reason Rietv
Looks very good to me; a couple of minor changes suggested.
http://codereview.appspot.com/5320074/diff/14001/input/regression/chord-additional-pitch-prefix.ly
File input/regression/chord-additional-pitch-prefix.ly (right):
http://codereview.appspot.com/5320074/diff/14001/input/regression/chord
Passes Make and reg test diffs here
http://code.google.com/p/lilypond/issues/detail?id=1503#c27
James
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Carl,
sorry patch needs rebasing again
-snip--
jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 <
../Desktop/issue5320074_11001.diff
patching file Documentation/included/chord-names-jazz.ly
patching file Documentation/notation/chords.itely
patching file Documentation/notation/notation-appendice
New patch set uploaded
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes Make. Reg test diffs are shown here
http://code.google.com/p/lilypond/issues/detail?id=1503#c20
James
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond
New patch set uploaded. Rebased to current master.
http://codereview.appspot.com/5320074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch doesn't apply to current master..
--snip--
jlowe@jlowe-lilybuntu2:~/lilypond-git$ patch -p1 <
../Desktop/issue5320074_2001.diff
patching file Documentation/included/chord-names-jazz.ly
patching file Documentation/notation/chords.itely
patching file Documentation/notation/notation-appendice
Reviewers: ,
Message:
I've uploaded Adam's changes for review.
I removed the spacing changes in scm/chord-ignatzek-names.scm awaiting
resolution on .scm indentation.
Description:
Fixes to jazz chord displays
This issue consists of a well-formed series of commits created by Adam
Spiers.
The co
21 matches
Mail list logo
