Re: Fixes multiple line glissandos the right way. (issue4631086)

2011-07-05 Thread m...@apollinemike.com
On Jul 4, 2011, at 11:49 PM, n.putt...@gmail.com wrote: > LGTM apart from some indentation infelicities (space before tab in > indent). > > http://codereview.appspot.com/4631086/ Infelicities incapacitated, pushed as 0c258f3f339573d25080dadd0a1a5078ec35b09a. Cheers, MS _

Re: Fixes multiple line glissandos the right way. (issue4631086)

2011-07-04 Thread Carl . D . Sorensen
LGTM Carl http://codereview.appspot.com/4631086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes multiple line glissandos the right way. (issue4631086)

2011-07-04 Thread n . puttock
LGTM apart from some indentation infelicities (space before tab in indent). http://codereview.appspot.com/4631086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixes multiple line glissandos the right way. (issue4631086)

2011-07-04 Thread mtsolo
Reviewers: , Message: Passes regtests - should be good to go! Thanks to Neil & Han-Wen for the help. Cheers, MS Description: Fixes multiple line glissandos the right way. Please review this at http://codereview.appspot.com/4631086/ Affected files: M lily/line-spanner.cc M scm/define-grobs