Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-23 Thread m...@apollinemike.com
On Mar 22, 2011, at 9:51 PM, Han-Wen Nienhuys wrote: > On Tue, Mar 22, 2011 at 7:54 PM, Neil Puttock wrote: >> On 22 March 2011 22:48, m...@apollinemike.com wrote: >> >>> Would an acceptable alternative be giving the TrillPitchAccidental the >>> inline-accidental-interface? >> >> Sounds good

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-22 Thread Han-Wen Nienhuys
On Tue, Mar 22, 2011 at 7:54 PM, Neil Puttock wrote: > On 22 March 2011 22:48, m...@apollinemike.com wrote: > >> Would an acceptable alternative be giving the TrillPitchAccidental the >> inline-accidental-interface? > > Sounds good to me. Sorry - I was confused. I was thinking that trill-pitch

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-22 Thread Neil Puttock
On 22 March 2011 22:48, m...@apollinemike.com wrote: > Would an acceptable alternative be giving the TrillPitchAccidental the > inline-accidental-interface? Sounds good to me. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http:

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-22 Thread m...@apollinemike.com
On Mar 22, 2011, at 6:46 PM, Neil Puttock wrote: > On 21 March 2011 01:59, Han-Wen Nienhuys wrote: > >> The intention of the fix is incorrect, but can you make the logic >> explicit? That is, add an interface symbol for "normal" accidentals >> (normal-accidental-interface, inline-accidental-inte

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-22 Thread Neil Puttock
On 21 March 2011 01:59, Han-Wen Nienhuys wrote: > The intention of the fix is incorrect, but can you make the logic > explicit? That is, add an interface symbol for "normal" accidentals > (normal-accidental-interface, inline-accidental-interface, ... ?) and > acknowledge that explicitly?  If not,

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-21 Thread hanwenn
LGTM http://codereview.appspot.com/4271054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-21 Thread mtsolo
Patch updated with Han Wen's suggestions. http://codereview.appspot.com/4271054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-20 Thread Han-Wen Nienhuys
On Sun, Mar 20, 2011 at 10:59 PM, Han-Wen Nienhuys wrote: > On Sun, Mar 20, 2011 at 8:41 AM,   wrote: >> Reviewers: , >> >> Message: >> Hey all, >> >> A bug just hit the French list.  It seems like a critical regression. >> > > Hi, > > There is not much else we can do: the suggestion accidental us

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-20 Thread Colin Campbell
On 11-03-20 05:41 AM, mts...@gmail.com wrote: Reviewers: , Message: Hey all, A bug just hit the French list. It seems like a critical regression. \score { %avec "surcharge" des ligatures double croches allongées \new Staff { \time 2/2 \set suggestAccidentals = ##t g'4 fis'8 [

Re: Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-20 Thread Han-Wen Nienhuys
On Sun, Mar 20, 2011 at 8:41 AM, wrote: > Reviewers: , > > Message: > Hey all, > > A bug just hit the French list.  It seems like a critical regression. > Hi, There is not much else we can do: the suggestion accidental uses the stem extent to determine Y positions, but that requires formatting

Fixes accidental suggestions in the beam collision engraver (issue4271054)

2011-03-20 Thread mtsolo
Reviewers: , Message: Hey all, A bug just hit the French list. It seems like a critical regression. \score { %avec "surcharge" des ligatures double croches allongées \new Staff { \time 2/2 \set suggestAccidentals = ##t g'4 fis'8 [ g'8 ] a'8 [ g'8 a'16 g'16 fis'!16 e'16 ]