Re: Fix issue 1605 (issue4377054)

2011-04-17 Thread Graham Percival
On Mon, Apr 18, 2011 at 03:53:45AM +, hanw...@gmail.com wrote: > doesnt dffe04e8e1a7c0b94fdfc30e44fe141dfbe7cbec already fix this? That patch follows ee02cd08e6bf81884323809241013c1834b413ed which is this (now closed) rietveld issue. Cheers, - Graham

Re: Fix issue 1605 (issue4377054)

2011-04-17 Thread hanwenn
On 2011/04/14 07:50:45, Graham Percival wrote: Could you swap the subject and message? i.e. I'd like to have a patch with first line of the commit being: PDF metadata for titles now handle unclosed parentheses I'd also be happy with: PDF metadata for titles now handle unclosed parent

Re: Fix issue 1605 (issue4377054)

2011-04-14 Thread percival . music . ca
Could you swap the subject and message? i.e. I'd like to have a patch with first line of the commit being: PDF metadata for titles now handle unclosed parentheses I'd also be happy with: PDF metadata for titles now handle unclosed parentheses (1605) but as it is, "fix issue 1605" means nothi

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
I added a line to the test. And I don't think we need to do something about newlines. http://codereview.appspot.com/4377054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread k-ohara5a5a
Works well for me. We should probably slip an unmatched parenthesis into the existing input/regression/pdfmark-metadata.ly I tested with \header {title = "A )little( \"night\" music\nfrom Mozart" } On 2011/04/12 11:51:01, Bertrand Bordage wrote: \markup "\n" and \markup "\t" The newline and

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread Carl . D . Sorensen
On 2011/04/12 13:33:05, Bertrand Bordage wrote: How ? output-ps is dependant of framework-ps... When I move it to output-ps, it doesn't work. Never mind. I don't know what I was thinking when I made that comment. Sorry, Carl http://codereview.appspot.com/4377054/ ___

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
How ? output-ps is dependant of framework-ps... When I move it to output-ps, it doesn't work. Thanks ! Bertrand http://codereview.appspot.com/4377054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypon

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread Carl . D . Sorensen
I'd recommend that the new function be placed in scm/output-ps.scm Thanks, Carl http://codereview.appspot.com/4377054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
Besides, I noticed two special markups : \markup "\n" and \markup "\t" What is their use ? I know \n stands for UNIX carriage return and \t stands for tab. But here... By the way, this doesn't cause any problem with metadata. http://codereview.appspot.com/4377054/ ___

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
Done. I don't know if this is the correct place for ps-quote. http://codereview.appspot.com/4377054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread Graham Percival
On Tue, Apr 12, 2011 at 10:30:39AM +, bordage.bertr...@gmail.com wrote: > Mistake : this produces the right output when we have title = "\a", but > PDF metadata is wrong and only shows "a". I'll include \\ in my next > update of the patch. I liked David's idea of having a separate function tha

Re: Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
Mistake : this produces the right output when we have title = "\a", but PDF metadata is wrong and only shows "a". I'll include \\ in my next update of the patch. http://codereview.appspot.com/4377054/ ___ lilypond-devel mailing list lilypond-devel@gnu.

Fix issue 1605 (issue4377054)

2011-04-12 Thread bordage . bertrand
Reviewers: , Message: This fixes issue 1605. Keith's patch takes the "\" bug into account. But this bug also occures with simple markups, so I assume this hasn't to be fixed. Description: Fix issue 1605 PDF metadata for titles now handle unclosed parentheses. Please review this at http://coder