Re: Fix issue 1376 ambitus two accidentals. (issue4099044)

2011-01-24 Thread percival . music . ca
On 2011/01/23 22:35:02, Neil Puttock wrote: Sorry Graham, my comment on the regtest should've been clearer: I wasn't proposing we add that information to the test (since it only applies to the new case fixed by this patch); it's just that the original text is ambiguous (the part about two n

Re: Fix issue 1376 ambitus two accidentals. (issue4099044)

2011-01-23 Thread Carl . D . Sorensen
LGTM. Carl http://codereview.appspot.com/4099044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 1376 ambitus two accidentals. (issue4099044)

2011-01-23 Thread n . puttock
On 2011/01/23 18:21:11, Graham Percival wrote: I've uploaded patchset 3, which I believe fixes all these. Sorry Graham, my comment on the regtest should've been clearer: I wasn't proposing we add that information to the test (since it only applies to the new case fixed by this patch); it's jus

Re: Fix issue 1376 ambitus two accidentals. (issue4099044)

2011-01-23 Thread percival . music . ca
Reviewers: Neil Puttock, Message: On 2011/01/23 18:00:23, Neil Puttock wrote: LGTM. Thanks! I've uploaded patchset 3, which I believe fixes all these. Cheers, - Graham Description: Fix issue 1376 ambitus two accidentals. Add regtest for 1376 ambitus accidentals. When an ambitus consists o

Fix issue 1376 ambitus two accidentals. (issue4099044)

2011-01-23 Thread n . puttock
LGTM. http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly File input/regression/ambitus.ly (right): http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly#newcode8 input/regression/ambitus.ly:8: Two noteheads are displayed even for a note with two differ