pushed by Graham as 1b99f1907fb77b0f3a0e65725776782c3eeaa025 (thanks - i
didn't have access to mi Lilydev machine lately).
I close Rietveld issue.
Thanks Julien!
Janek
http://codereview.appspot.com/4996044/
___
lilypond-devel mailing list
lilypond-de
passes make and reg tests
http://codereview.appspot.com/4996044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2011/9/9 :
> http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#oldcode691
> scripts/lilypond-book.py:691: + '.%s' % global_options.format)
> On 2011/09/09 19:19:47, janek wrote:
>>
>> Pardon my ignorance, but what the
>> '.%s' %
>> part was doing before?
>
> It simply prepended
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode681
scripts/lilypond-book.py:681: chunks = do_file (files[0])
you mean "that do_file BELOW", right?
woah, you
LGTM, although I would also move that code changing
global_options.output_dir from do_file to main, to make things much
clearer!
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (left):
http://codereview.appspot.com/4996044/diff/1/scripts/lilyp
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode677
scripts/lilypond-book.py:677: relative_output_dir =
global_options.output_dir
did you want an
os.path.re
Hi,
as usual my review will contain only questions...
Please pardon my ignorance, i don't know what this area of the code
does. However, what your patch does seems reasonable to me.
http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (left):
htt
Reviewers: julien.rioux_gmail.com, Graham Percival,
Message:
By Julien Rioux.
Description:
Fix issue #1852: manuals needs more explicit dependencies.
Dependencies are already being tracker by lilypond-book.py,
which produces .dep files containing make rules. The file
stepmake/stepmake/generic-t
