Re: Fix for beaming in Kievan notation (issue 6305080)

2012-09-09 Thread aleksandr . andreev
Please review. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-08-08 Thread aleksandr . andreev
On 2012/08/07 18:19:14, dak wrote: http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636 lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads); This looks like the wrong place to do this calculation. You overwrite what has been put into quantized-positions here.

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-08-07 Thread dak
http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636 lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads); This looks like the wrong place to do this calculation. You overwri

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-08-04 Thread aleksandr . andreev
This is definitely not an elegant approach to the problem at all (and it does not solve the issue of the warning being given out at stem.cc line 128), but it's the best I can figure out after hacking at the code for a while. Perhaps reviewers more familiar with LilyPond internals can provide some

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-06-11 Thread aleksandr . andreev
On 2012/06/11 00:49:42, Keith wrote: looks good to me. The question I have now is how to affect the position of the beam. It needs to attach toward the bottom of the "stem" and not at center of the staff. http://codereview.appspot.com/6305080/ ___ l

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-06-10 Thread k-ohara5a5a
looks good to me. http://codereview.appspot.com/6305080/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix for beaming in Kievan notation (issue 6305080)

2012-06-10 Thread aleksandr . andreev
Reviewers: , Message: A first attempt at fixing issue 2492. This fixes the note heads for beamed kievan notes, also getting rid of the warning messages. Description: Fix for beaming in Kievan notation Implementing correct beaming functionality in Kievan notation Fix for Issue 2492 Please rev