Thanks for the ping, it's been a long time! Sadly, I haven't used
lilypond for years. I tried to update my patch, but I cannot spend too
much time on it.
I see that my change to engraver.cc is no longer needed, as there is a
check there that was missing back at the time. The change to
engraver-sche
http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc
File lily/engraver-scheme.cc (right):
http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc#newcode42
lily/engraver-scheme.cc:42: programming_error ("cannot create grob");
This gives no helpful indication o
On 2012/03/03 04:38:36, Pavel Roskin wrote:
I'm not getting any interesting information:
...
[/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly]
[/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]]
[bad.ly]
Interpreting music...
[/usr/local/share/lilypond/2.15.32/fonts/otf/
I'm not getting any interesting information:
...
[/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly]
[/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]]
[bad.ly]
Interpreting music...
[/usr/local/share/lilypond/2.15.32/fonts/otf/emmentaler-20.otf]
fatal error: failed files: "bad
On Fri, Mar 2, 2012 at 10:22 PM, wrote:
> There are only two calls to scm_throw in Lilypond, and I could not find
> out whether it should be added to engraver.cc or engraver-scheme.cc. I
> added it to the former so that other callers to
> Engraver::internal_make_grob could benefit. I could not
There are only two calls to scm_throw in Lilypond, and I could not find
out whether it should be added to engraver.cc or engraver-scheme.cc. I
added it to the former so that other callers to
Engraver::internal_make_grob could benefit. I could not figure out how
to catch an exception. Without ca
On 2012/03/01 23:02:57, Pavel Roskin wrote:
I've seen it many times that Lilypond would crash during my
experiments with
Scheme code. This time I decided to track it down. It's my first
ever fix to
the C++ code in Lilypond, so please check my coding style.
How is that a fix? You return a
Reviewers: ,
Message:
I've seen it many times that Lilypond would crash during my experiments
with Scheme code. This time I decided to track it down. It's my first
ever fix to the C++ code in Lilypond, so please check my coding style.
Description:
Fix crash when unknown grob name is passed to
