Re: Fix a few complaints in python/convertrules.py (issue 583290043 by d...@gnu.org)

2020-01-12 Thread jonas . hahnfeld
Thanks, LGTM https://codereview.appspot.com/583290043/

Re: Fix a few complaints in python/convertrules.py (issue 583290043 by d...@gnu.org)

2020-01-11 Thread dak
Reviewers: hahnjo, https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774 python/convertrules.py:1774: str += "'" * (o + 1) On 2020/01/08 08:17

Re: Fix a few complaints in python/convertrules.py (issue 583290043 by d...@gnu.org)

2020-01-08 Thread jonas . hahnfeld
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode3973 python/convertrules.py:3973: if re.search (r"#(banter|jazz)-chordnames", str): On 2020/0

Fix a few complaints in python/convertrules.py (issue 583290043 by d...@gnu.org)

2020-01-08 Thread jonas . hahnfeld
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774 python/convertrules.py:1774: str += "'" * (o + 1) I agree that this is equivalent, but s