LGTM
http://codereview.appspot.com/3693042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Thanks for the review, Patrick.
I've made the changes and posted a new patch set.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhyth
Just some Nitpicks
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode
Documentation/notation/rhythms.itely::
LGTM.
http://codereview.appspot.com/3693042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Thanks for the excellent feedback. I've fixed everything now.
A revised patch set is available.
http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (left):
http://codereview.appspot.com/3693042/diff/1/Documentation/nota
http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (left):
http://codereview.appspot.com/3693042/diff/1/Documentation/notation/rhythms.itely#oldcode1059
Documentation/notation/rhythms.itely:1059: \relative c' {
\new Staff
From:
> To:
> Cc: ;
> Sent: Friday, December 17, 2010 1:53 PM
> Subject: Re: Fix 1456 (issue3693042)
>
>
>> Looks fine from a quick eyeball, but I haven't tested it.
>>
>>
>> We've had a few people bragging about their computers lately, so
- Original Message -
From:
To:
Cc: ;
Sent: Friday, December 17, 2010 1:53 PM
Subject: Re: Fix 1456 (issue3693042)
Looks fine from a quick eyeball, but I haven't tested it.
We've had a few people bragging about their computers lately, so could
one of them try applying
Looks fine from a quick eyeball, but I haven't tested it.
We've had a few people bragging about their computers lately, so could
one of them try applying this patch and make sure that everything
compiles from scratch? Using the lilybuntu instructions, "from scratch"
means removing the build/ di
oops, I hit "reply to comment" intead of "publish+send". Here's my only
comment on the patch.
http://codereview.appspot.com/3693042/diff/1/input/regression/skiptypesetting-multimeasurerest.ly
File input/regression/skiptypesetting-multimeasurerest.ly (right):
http://codereview.appspot.com/36930
Reviewers: ,
Message:
Here's a fix for issue 1456.
I've taken the context argument out of \overrideTimeSignatureSettings
and \revertTimeSignatureSettings. They now apply to the Timing context.
I've also added an example showing how to have different time signature
settings in different staves.
11 matches
Mail list logo
