Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-18 Thread Trevor Daniels
From: Thursday, February 17, 2011 6:32 PM Ok, it seems we're all ok with this. Keith, please email the patch to Trevor for pushing. http://codereview.appspot.com/4187043/ Pushed: 6d751144f402dc58ff3f65df0fcaab021a86908c and reg tests bumped to 2.13.51: 6ca2619b3ae13ae94b8f43b124e92d86e

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-17 Thread percival . music . ca
Ok, it seems we're all ok with this. Keith, please email the patch to Trevor for pushing. http://codereview.appspot.com/4187043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread Trevor Daniels
Keith OHara wrote Wednesday, February 16, 2011 8:54 PM On Wed, 16 Feb 2011 08:08:10 -0800, wrote: On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread Keith OHara
On Wed, 16 Feb 2011 08:08:10 -0800, wrote: On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if lyrics are spaced to clear that protrusion. The bar-lines th

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread tdanielsmusic
On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if lyrics are spaced to clear that protrusion. The bar-lines then slide past this assumed position of lyrics.

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-15 Thread Neil Puttock
On 15 February 2011 18:36, wrote: > Whether bar-lines avoiding lyrics is good thing or not, no-one is likely > to ever see it in anything longer than a couple bars. That's exactly what I thought too (and was borne out in every snippet I tested). > Does this argument put the patch in LGTM state

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-15 Thread k-ohara5a5a
On 2011/02/14 23:25:21, Keith wrote: On Mon, 14 Feb 2011 13:43:37 -0800, wrote: > My only concern with these changes is the barline avoidance (which you > mention in the tracker as possibly a good thing). There's one regtest > which shows the problem: in `song

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-14 Thread Keith OHara
On Mon, 14 Feb 2011 13:43:37 -0800, wrote: My only concern with these changes is the barline avoidance (which you mention in the tracker as possibly a good thing). There's one regtest which shows the problem: in `song-melisma.ly', some extra space has appeared in the second bar around `daah'.

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-14 Thread n . puttock
Hi Keith, My only concern with these changes is the barline avoidance (which you mention in the tracker as possibly a good thing). There's one regtest which shows the problem: in `song-melisma.ly', some extra space has appeared in the second bar around `daah'. Cheers, Neil http://codereview.ap

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-12 Thread k-ohara5a5a
Very simple fix to the skyline implementation, and now skyline-vertical-padding behaves as expected in detail. http://codereview.appspot.com/4187043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-11 Thread Keith OHara
On Fri, 11 Feb 2011 23:16:46 -0800, wrote: On 2011/02/12 06:29:55, Keith wrote: Phooey. This needs work. Notes on ledger lines below the staff can slide past the final bar line, Iff there is only one item in a NonMusicalPaperColumn, then it receives only the sloped portion of the skyline o

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-11 Thread k-ohara5a5a
On 2011/02/12 06:29:55, Keith wrote: Phooey. This needs work. Notes on ledger lines below the staff can slide past the final bar line, Iff there is only one item in a NonMusicalPaperColumn, then it receives only the sloped portion of the skyline on the bottom, not the flat portion plus sloped

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-11 Thread k-ohara5a5a
Phooey. This needs work. Notes on ledger lines below the staff can slide past the final bar line, although the current skyline extension should in theory reach 1.2 staff-space beyond the barline to stop them. It seems that skyline-vertical-padding does not act symmetrically top-to-bottom. If I

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-11 Thread Carl . D . Sorensen
LGTM. Thanks, Keith! Carl http://codereview.appspot.com/4187043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel