Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

2010-08-13 Thread n . puttock
On 2010/08/13 22:25:43, Carl wrote: Let me know about the filename for the new callbacks, and I'll add that to this patch and push it. I'd be happy with scm/define-music-callbacks.scm. Cheers, Neil http://codereview.appspot.com/1986042/show ___ l

Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

2010-08-13 Thread Carl . D . Sorensen
Let me know about the filename for the new callbacks, and I'll add that to this patch and push it. THanks, Carl http://codereview.appspot.com/1986042/diff/1/2 File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/1986042/diff/1/2#newcode887 scm/define-music-display-

Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

2010-08-13 Thread n . puttock
Hi Carl, LGTM. Cheers, Neil http://codereview.appspot.com/1986042/diff/1/2 File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/1986042/diff/1/2#newcode887 scm/define-music-display-methods.scm:887: (let* ((arguments (ly:music-property expr 'time-signature-arguments

Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)

2010-08-12 Thread Carl . D . Sorensen
Reviewers: Neil Puttock, Message: I've posted a patch that fixes 1198 so \time and (set-time-signature will now be displayed properly. Thanks, Neil for showing how it could be done with ottava. Please review. Thanks, Carl Description: Fix 1198: Fix displayLilyMusic for \time and #(set-time-s