On 2019/10/26 14:57:32, Dan Eble wrote:
I don't have time right now to test that this still works when tidy is
installed, but since it's blocking others, I see no problem with
pushing it to
staging.
It's not just that there "is no problem". Without working test
procedures, the state of this
I don't have time right now to test that this still works when tidy is
installed, but since it's blocking others, I see no problem with pushing
it to staging.
https://codereview.appspot.com/573150043/
On 2019/10/26 08:51:34, hahnjo wrote:
This is not about removing the warning message that an optional
dependency
cannot be found, that is fine in my opinion. The problem is that the
check in
GNUmakefile.in for an empty value was wrong and it tries to execute
tidy despite
not being there.
On 2019/10/25 20:10:08, Dan Eble wrote:
Thanks for this. Seeing a warning message for an optional program
bothered me,
but addressing it was out of my depth.
This is not about removing the warning message that an optional
dependency cannot be found, that is fine in my opinion. The problem is
Thanks for this. Seeing a warning message for an optional program
bothered me, but addressing it was out of my depth.
What do you think about using "false" rather than "no" if the program is
not found? That would be more defensive because if "$(TIDY) ..." is
executed as "false ...", we can be p
LGTM
https://codereview.appspot.com/573150043/
