Re: Fix #887: Use ly:string-percent-encode for textedit URIs. (issue193077)

2010-01-28 Thread pnorcks
Reviewers: lemzwerg, dak, Message: On 2010/01/25 09:28:36, dak wrote: http://codereview.appspot.com/193077/diff/1001/12 File lily/general-scheme.cc (right): http://codereview.appspot.com/193077/diff/1001/12#newcode230 lily/general-scheme.cc:230: return ((c >= 0x2D && c <= 0x2F) // hyphen, f

Re: Fix #887: Use ly:string-percent-encode for textedit URIs. (issue193077)

2010-01-25 Thread dak
http://codereview.appspot.com/193077/diff/1001/12 File lily/general-scheme.cc (right): http://codereview.appspot.com/193077/diff/1001/12#newcode230 lily/general-scheme.cc:230: return ((c >= 0x2D && c <= 0x2F) // hyphen, full-stop, and forward-slash On 2010/01/25 06:38:18, lemzwerg wrote: Wouldn

Fix #887: Use ly:string-percent-encode for textedit URIs. (issue193077)

2010-01-24 Thread lemzwerg
http://codereview.appspot.com/193077/diff/1001/12 File lily/general-scheme.cc (right): http://codereview.appspot.com/193077/diff/1001/12#newcode230 lily/general-scheme.cc:230: return ((c >= 0x2D && c <= 0x2F) // hyphen, full-stop, and forward-slash Wouldn't it be faster to use an array of `0' an