Re: Fix #1695: Clef change placed outside score. (issue4683043)

2011-07-20 Thread Neil Puttock
On 14 July 2011 15:59, wrote: > LGTM. > > Careful thinking about how to handle this.  Great job, Neil! Thanks. It took several drafts before I was happy with the explanation. :) (pushed: bebd93c2dd0d7363f311d912ec1ed1f7dfcb36ba) Cheers, Neil ___ li

Re: Fix #1695: Clef change placed outside score. (issue4683043)

2011-07-20 Thread n . puttock
On 2011/07/19 22:38:30, Graham Percival wrote: Please push this; we'd like to get back to 0 Critical issues. I'm working on it now. Cheers, Neil http://codereview.appspot.com/4683043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://

Re: Fix #1695: Clef change placed outside score. (issue4683043)

2011-07-19 Thread percival . music . ca
Hi Neil, Please push this; we'd like to get back to 0 Critical issues. Cheers, - Graham http://codereview.appspot.com/4683043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix #1695: Clef change placed outside score. (issue4683043)

2011-07-14 Thread Carl . D . Sorensen
LGTM. Careful thinking about how to handle this. Great job, Neil! http://codereview.appspot.com/4683043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix #1695: Clef change placed outside score. (issue4683043)

2011-07-13 Thread n . puttock
Reviewers: , Message: A MetronomeMark represents a special case for a break-alignable grob, since sometimes it will be aligned on noteheads rather than prefatory material. In this case, we don't want it to be acknowledged by the Break_alignment_engraver, since it will hijack the X-parent before