On 2011/02/06 21:13:34, nicolas.sceaux wrote:
http://codereview.appspot.com/2145047/diff/6001/scm/define-music-display-methods.scm
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/2145047/diff/6001/scm/define-music-display-methods.scm#newcode927
scm/define-mus
argh, I just sent the 48-hour notice before checking the regtests.
Minor issue:
input/regression/display-lily-tests.log
no longer prints a warning for "test 90 unequal".
I know that you know \displayMusic better than anybody else, so I'm not
worried about this. :)
http://codereview.appspot.com
http://codereview.appspot.com/2145047/diff/6001/scm/define-music-display-methods.scm
File scm/define-music-display-methods.scm (right):
http://codereview.appspot.com/2145047/diff/6001/scm/define-music-display-methods.scm#newcode927
scm/define-music-display-methods.scm:927: (format #f "\\tempo ~{
LGTM
http://codereview.appspot.com/2145047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/22 20:34:05, Graham Percival wrote:
Unfortunately this patch no longer applies cleanly to git master.
It should work fine now.
Cheers,
Neil
http://codereview.appspot.com/2145047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
htt
Unfortunately this patch no longer applies cleanly to git master.
http://codereview.appspot.com/2145047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2010/11/27 00:27:27, Valentin Villenave wrote:
Wow, I can understand why my patch would wreak havoc through your
work!
I only had a quick look, but it certainly does look elegant. If you
don't mind
my asking, what makes it better to have a tempo-change event rather
than just
waiting for
On 2010/09/12 21:42:50, Neil Puttock wrote:
This patch changes the internal representation of \tempo so it uses an
event to
trigger creation of a metronome mark.
Wow, I can understand why my patch would wreak havoc through your work!
I only had a quick look, but it certainly does look elegant
Reviewers: ,
Message:
Hi,
This patch changes the internal representation of \tempo so it uses an
event to trigger creation of a metronome mark.
Please review.
Thanks,
Neil
Description:
Fix #1205.
Reinstate an event for \tempo, instead of relying on context property
changes.
Please review th
