Marc Hohl schrieb:
Carl D. Sorensen schrieb:
On 7/7/09 12:20 PM, "Marc Hohl" wrote:
[...]
I don't particularly mind breaking existing scores (as long as
there is
a convert-ly rule to at least warn about the problem), but I
don't think
the situation in the patch is particularly frien
Carl D. Sorensen schrieb:
On 7/7/09 12:20 PM, "Marc Hohl" wrote:
[...]
I don't particularly mind breaking existing scores (as long as there is
a convert-ly rule to at least warn about the problem), but I don't think
the situation in the patch is particularly friendly. We've a long
tr
Carl D. Sorensen schrieb:
[...]
3) move the existing predefined tunings from scm/output-lib.scm
into tablature.scm, where I can add my new tunings as well;
Yes, I agree with this.
Should the definitions for fret-number-tablature-format
and fret-number-tablature-format-banjobe move
On 7/7/09 12:20 PM, "Marc Hohl" wrote:
> [...]
I don't particularly mind breaking existing scores (as long as there is
a convert-ly rule to at least warn about the problem), but I don't think
the situation in the patch is particularly friendly. We've a long
tradition of cho
[...]
I don't particularly mind breaking existing scores (as long as there is
a convert-ly rule to at least warn about the problem), but I don't think
the situation in the patch is particularly friendly. We've a long
tradition of choosing sensible behaviour over backwards compatibility
and I see
On 7/7/09 1:56 AM, "Marc Hohl" wrote:
> Joe Neeman schrieb:
>> On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote:
>>
http://codereview.appspot.com/67174/diff/1/2#newcode237
Line 237: \layout {
It seems to me that we have 3 versions of tablature now: the "default"
Joe Neeman schrieb:
On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote:
http://codereview.appspot.com/67174/diff/1/2#newcode237
Line 237: \layout {
It seems to me that we have 3 versions of tablature now: the "default"
version in engraver-init.ly, the version that appears if the user
i
On Tue, 2009-06-23 at 12:53 -0600, Carl D. Sorensen wrote:
> > http://codereview.appspot.com/67174/diff/1/2#newcode237
> > Line 237: \layout {
> > It seems to me that we have 3 versions of tablature now: the "default"
> > version in engraver-init.ly, the version that appears if the user
> > include
Thanks, Joe.
On 6/23/09 12:31 PM, "joenee...@gmail.com" wrote:
> I don't know much about the issues here, but here's a review, fwiw. Of
> course, you'll need to update the docs also (and a regression test or 2
> would be nice).
Yep, docs and regressions are in the works. (Although Graham says
I don't know much about the issues here, but here's a review, fwiw. Of
course, you'll need to update the docs also (and a regression test or 2
would be nice).
http://codereview.appspot.com/67174/diff/1/2
File ly/tablature.ly (right):
http://codereview.appspot.com/67174/diff/1/2#newcode205
Line
10 matches
Mail list logo
