LGTM.
I like the results!
http://codereview.appspot.com/4518052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
:)
Thanks ! This works great. Updated.
http://codereview.appspot.com/4518052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/05/11 09:54:36, dak wrote:
Something like
fatten := min(number/256,1)[1+fatten_factor,1];
should do the trick then.
Well, I repeat the suggestion to make fatten_factor neutral at 1 instead
of 0 (resulting in omitting 1+ in the above formula), and perhaps
instead of hardcoding 256, one c
On 2011/05/11 09:22:14, Bertrand Bordage wrote:
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151
mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number *
fa
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151
mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number *
fatten_factor / 256, fatten_factor);
Thanks !
Hum...
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151
mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number *
fatten_factor / 256, fatten_factor);
This is a bit ob
I don't know if this is a joke, so I answer to David's question :
of course there is no jump between the 256th and the 257th !
Refer to this message to see before/after :
http://lists.gnu.org/archive/html/lilypond-devel/2011-05/msg00150.html
http://codereview.appspot.com/4518052/
___
2011/5/11 Francisco Vila :
> 2011/5/11 :
>> If you say you fatten the first 256 braces, does that mean that there is
>> a jump in thickness when going from the 256th to the 257th brace?
>
> Is it a joke?
Oh, of course it is. Sorry :*)
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.cs
2011/5/11 :
> If you say you fatten the first 256 braces, does that mean that there is
> a jump in thickness when going from the 256th to the 257th brace?
Is it a joke?
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com
___
lilyp
If you say you fatten the first 256 braces, does that mean that there is
a jump in thickness when going from the 256th to the 257th brace?
In that case, would it not be better to have a smoother transition
rather than a jump? Metafont is good at curves, after all...
http://codereview.appspot.co
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode150
mf/feta-braces.mf:150: save fatten;
That's what I thought at first. Then I saw "save number;" line 129, so I
decided to p
LGTM, apart from one nitpick. I much prefer your
redesigned braces!
Trevor
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode150
mf/feta-braces.mf:150: save fatten;
I don'
Reviewers: carl.d.sorensen_gmail.com,
Message:
Thanks for the review !
Patch updated.
I don't know if there's a better way to solve this issue.
As big braces look good, I decided to limit the changes to the smallest
ones.
Description:
Fattens the 256 first braces.
Please review this at http://c
LGTM, with a small nitpick.
I like the new braces better.
Carl
http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf
File mf/feta-braces.mf (right):
http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf#newcode148
mf/feta-braces.mf:148: fatten_factor := 1.5;
I think that go
14 matches
Mail list logo
