Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-16 Thread n . puttock
On 2010/03/15 09:53:31, marc wrote: > http://codereview.appspot.com/224082/diff/1012/19 > File ly/chord-repetition-init.ly (right): > > http://codereview.appspot.com/224082/diff/1012/19#newcode71 > ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '())) > indent > > #(define >

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-14 Thread n . puttock
Hi Marc, Here are a few more comments for you. Cheers, Neil http://codereview.appspot.com/224082/diff/1012/17 File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/224082/diff/1012/17#newcode256 Documentation/notation/fretted-strings.itely:256: is provided.

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-02 Thread Neil Puttock
On 2 March 2010 11:25, Marc Hohl wrote: > Thanks. Can you please push it? I am not allowed to... I'm happy to push, but there seems to be a problem: the default repetition function is the tablature version; I think this is due to the parser evaluating the scheme code in the `tabChordRepetition'

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-02 Thread Marc Hohl
Nicolas Sceaux schrieb: Le 1 mars 2010 à 20:24, Marc Hohl a écrit : Nicolas Sceaux schrieb: Shouldn't there be a few words of explantion about using q and \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted strings"? Done. I hope it is ok. Marc http://codere

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-02 Thread Nicolas Sceaux
Le 1 mars 2010 à 20:24, Marc Hohl a écrit : > Nicolas Sceaux schrieb: >> >> Shouldn't there be a few words of explantion about using q and >> \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted >> strings"? >> > Done. I hope it is ok. > > Marc > > http://codereview.appspot.co

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-01 Thread Marc Hohl
Nicolas Sceaux schrieb: Le 1 mars 2010 à 10:00, Marc Hohl a écrit : nicolas.sce...@gmail.com schrieb: http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-init.ly:51: #(defin

Re: Error in fretted-strings.itely? (was: Re: Enhancement: tabalture chord repetition (issue224082))

2010-03-01 Thread Jonathan Kulp
On Mon, Mar 1, 2010 at 5:47 AM, Jonathan Kulp wrote: > On Mon, Mar 1, 2010 at 5:20 AM, Marc Hohl wrote: > >> Marc Hohl schrieb: >> >>> Nicolas Sceaux schrieb: >>> Le 1 mars 2010 à 10:00, Marc Hohl a écrit : > nicolas.sce...@gmail.com schrieb: > > >> http://code

Re: Error in fretted-strings.itely? (was: Re: Enhancement: tabalture chord repetition (issue224082))

2010-03-01 Thread Jonathan Kulp
On Mon, Mar 1, 2010 at 5:20 AM, Marc Hohl wrote: > Marc Hohl schrieb: > >> Nicolas Sceaux schrieb: >> >>> Le 1 mars 2010 à 10:00, Marc Hohl a écrit : >>> >>> >>> nicolas.sce...@gmail.com schrieb: > http://codereview.appspot.com/224082/diff/1/3 > File ly/chord-repetition-ini

Error in fretted-strings.itely? (was: Re: Enhancement: tabalture chord repetition (issue224082))

2010-03-01 Thread Marc Hohl
Marc Hohl schrieb: Nicolas Sceaux schrieb: Le 1 mars 2010 à 10:00, Marc Hohl a écrit : nicolas.sce...@gmail.com schrieb: http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-i

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-01 Thread Marc Hohl
Nicolas Sceaux schrieb: Le 1 mars 2010 à 10:00, Marc Hohl a écrit : nicolas.sce...@gmail.com schrieb: http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-init.ly:51: #(defin

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-01 Thread Nicolas Sceaux
Le 1 mars 2010 à 10:00, Marc Hohl a écrit : > nicolas.sce...@gmail.com schrieb: >> >> http://codereview.appspot.com/224082/diff/1/3 >> File ly/chord-repetition-init.ly (right): >> >> http://codereview.appspot.com/224082/diff/1/3#newcode51 >> ly/chord-repetition-init.ly:51: #(define-public (tab-r

Re: Enhancement: tabalture chord repetition (issue224082)

2010-03-01 Thread Marc Hohl
nicolas.sce...@gmail.com schrieb: http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord previous-chord location duration articulations) It

Re: Enhancement: tabalture chord repetition (issue224082)

2010-02-28 Thread nicolas . sceaux
On 2010/02/28 16:27:07, nicolas.sceaux wrote: http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord previous-chord location duration art

Enhancement: tabalture chord repetition (issue224082)

2010-02-28 Thread nicolas . sceaux
http://codereview.appspot.com/224082/diff/1/3 File ly/chord-repetition-init.ly (right): http://codereview.appspot.com/224082/diff/1/3#newcode51 ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord previous-chord location duration articulations) It would be better to define a generi