If I understand well, there's no need anymore for manual beams in
cross-staff cases ?
If so, I suggest you remove the manual beams from
input/regression/beam-collision-cross-staff.ly.
You should also remove the knownissues in keyboard.itely and the last
part of changes.tely's entry.
Thanks,
Bertr
On 2011/06/01 05:59:21, Keith wrote:
On 2011/05/31 08:19:42, joeneeman wrote:
> the Beam's Y-parent will be the VerticalAxisGroup of the bottom
staff
> and Beam::calc_cross_staff will return false.
Old patch didn't; but new patch does. LGTM
Thanks, pushed. Also removed the 3 lines suggest
On 2011/05/31 08:19:42, joeneeman wrote:
the Beam's Y-parent will be the VerticalAxisGroup of the bottom staff
and Beam::calc_cross_staff will return false.
Old patch didn't; but new patch does. LGTM
http://codereview.appspot.com/4564041/
___
lilyp
Hey Joe,
Lines 1207-1209 in beam.cc are a kludge that I believe your patch
resolves. You
may want to consider removing these lines and testing to see if it
still passes
regtests. If so, I think you can nix these lines permanently.
After fixing my patch, I can indeed remove those lines.
On May 31, 2011, at 9:19 AM, joenee...@gmail.com wrote:
> Reviewers: Keith,
>
> Message:
> On 2011/05/28 18:43:19, Keith wrote:
>> I would love to test, but don't know enough of the internals to see
> what this
>> does.
>
> If you take your example from comment 5 of issue 1043, without manual
>
Reviewers: Keith,
Message:
On 2011/05/28 18:43:19, Keith wrote:
I would love to test, but don't know enough of the internals to see
what this
does.
If you take your example from comment 5 of issue 1043, without manual
beaming, the Beam's Y-parent will be the VerticalAxisGroup of the top
staf
I would love to test, but don't know enough of the internals to see what
this does.
http://codereview.appspot.com/4564041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
