Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

2012-09-03 Thread graham
http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/3001/lily/self-alignment-interface.cc#newcode205 lily/self-alignment-interface.cc:205: // if coll is cross staff but extremal

Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

2012-09-03 Thread graham
adds programming errors. I've set it to patch-needs_work. http://codereview.appspot.com/6493073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

2012-09-02 Thread mtsolo
Reviewers: dak, Message: Thanks for the review! http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc

Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)

2012-09-02 Thread dak
http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213 lily/self-alignment-interface.cc:213: vector_sort (vais, less ()); Seriously? If