Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-25 Thread Joe Neeman
On Tue, Aug 23, 2011 at 12:36 AM, Mike Solomon wrote: > On Aug 23, 2011, at 6:55 AM, joenee...@gmail.com wrote: > >> >> http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc >> File lily/bezier.cc (right): >> >> http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 >> lily/b

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-25 Thread Han-Wen Nienhuys
On Thu, Aug 25, 2011 at 4:40 AM, wrote: > Pushed as 29d1121d260318ed07f152c346a1a69e5dadb69d. > > Many thanks to Joe and Han-Wen for your comments. > > Han-Wen: I didn't hear back from you regarding the intervals for minmax, > so I went ahead and kept them returning Real values.  Lemme know if yo

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-25 Thread mtsolo
Pushed as 29d1121d260318ed07f152c346a1a69e5dadb69d. Many thanks to Joe and Han-Wen for your comments. Han-Wen: I didn't hear back from you regarding the intervals for minmax, so I went ahead and kept them returning Real values. Lemme know if you still want them to return intervals and I'll uplo

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 6:55 AM, joenee...@gmail.com wrote: > > http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc > File lily/bezier.cc (right): > > http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 > lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-23 Thread Mike Solomon
On Aug 23, 2011, at 6:21 AM, hanw...@gmail.com wrote: > > http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc > File flower/polynomial.cc (right): > > http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80 > flower/polynomial.cc:80: return ret_max ? sols.

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-22 Thread joeneeman
http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc File lily/bezier.cc (right): http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239 lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d != LEFT); On 2011/08/19 07:03:50, MikeSol wrote: On 2011/08/18 21:3

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-22 Thread hanwenn
http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80 flower/polynomial.cc:80: return ret_max ? sols.back () : sols[0]; you could return an interval instead; Polynomi

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-19 Thread mtsolo
Thanks Joe! New patchset uploaded. Cheers, MS http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc#newcode65 flower/polynomial.cc:65: Polynomial::minmax (Real l, Real r, bool dir)

Re: Does better polynomial calculations for avoid objects. (issue 4860042)

2011-08-18 Thread joeneeman
http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc File flower/polynomial.cc (right): http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc#newcode65 flower/polynomial.cc:65: Polynomial::minmax (Real l, Real r, bool dir) const Perhaps "bool max" instead of "bool dir"?