Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-04-04 Thread pkx166h
Pushed as commit 85fe0f15000f793435221fab2688ba3fa65a028f http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-04-02 Thread percival . music . ca
LGTM http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-04-02 Thread pkx166h
anymore for anymore? http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-04-02 Thread pkx166h
anymore for anymore? http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-30 Thread pkx166h
Draft #3 posted. http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Single beat repeats for sixteenth or shorter n

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-29 Thread n . puttock
http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/4273125/diff/1002/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Single beat repeats for sixteenth or shorter notes and beat repe

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread pkx166h
Second Draft. http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread pkx166h
Reviewers: Neil Puttock, Graham Percival, Message: On 2011/03/28 20:04:37, Neil Puttock wrote: Hi James, Thanks for doing this. It LGTM (but don't forget to remove the @knownissue) Thanks, I missed that. Done. Just two suggestions for you: a changes.itely entry is probably a good idea,

Re: Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread percival . music . ca
LTGM, and I agree with Neil's comments. http://codereview.appspot.com/4273125/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR more examples to Repeats for beat slashes (issue4273125)

2011-03-28 Thread n . puttock
Hi James, Thanks for doing this. It LGTM (but don't forget to remove the @knownissue) Just two suggestions for you: a changes.itely entry is probably a good idea, and the @seealso for the Internals Reference needs the following items added: DoublePercentEvent DoubleRepeatSlash Double_percent_r