Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-30 Thread graham
LGTM http://codereview.appspot.com/5520056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-29 Thread pkx166h
http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1358 Documentation/notation/rhythms.itely:1358: The @var{duration} c

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-24 Thread janek . lilypond
mostly LGTM http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1358 Documentation/notation/rhythms.itely:1358: The @va

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-24 Thread graham
looks mostly good. http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/7001/Documentation/notation/rhythms.itely#newcode1358 Documentation/notation/rhythms.itely:1358:

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-24 Thread pkx166h
http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1350 Documentation/notation/rhythms.itely:1350: partial measure @emph{befo

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-10 Thread janek . lilypond
http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1350 Documentation/notation/rhythms.itely:1350: partial measure @emph{befo

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-09 Thread n . puttock
Note that this is misleading: \relative c' { \partial 4 c4 \applyContext #(lambda (ctx) (newline) (display (ly:context-current-moment ctx))) c1 } -> # The Rational class doesn't display negative rationals unless they're infinite. http://coderevi

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-09 Thread n . puttock
On 2012/01/09 12:58:58, Neil Puttock wrote: http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1366 Documentation/notatio

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-09 Thread n . puttock
http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1366 Documentation/notation/rhythms.itely:1366: The @code{\partial @var{du

Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-08 Thread graham
I like some of the changes here, but I have serious doubts about others. http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode

Doc: NR Section on Upbeats made clearer (issue 5520056)

2012-01-06 Thread pkx166h
Reviewers: , Message: I'm not convinced knowing more than I did back when I originally edited this part of the doc (it was one of my first patches i ever did so I was taking advice from others). --snip from NR -- The property measurePosition contains a rational number indicating how much of the